Removed Search UI access for Editor role#103951
Closed
JasonStoltz wants to merge 1 commit intoelastic:masterfrom
Closed
Removed Search UI access for Editor role#103951JasonStoltz wants to merge 1 commit intoelastic:masterfrom
JasonStoltz wants to merge 1 commit intoelastic:masterfrom
Conversation
Member
Author
|
Hey @spalger , I'd like this to backport to 7.14 also. SO I'd need 7.15 and 7.14 no? |
Contributor
|
@JasonStoltz sounds good, just doing general maintenance to all PRs open targeting 7.14 without targeting 7.15 to make sure that PRs aren't accidentally backported to 7.14 without being backported to the 7.x branch. You and your reviewers ultimately make the call about where it goes 👍 |
Member
Author
|
Makes sense, thanks! 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR disables access for Editors to the Search UI page in Kibana only.
The Search UI page now requires the ability to view credentials because it posts a Search API Key to ent-search to generate a preview.
Editors do not have this access. For that reason Search UI does NOT work for that role in the Kibana Plugin.
Because Editors should still have access to this page in ent-search, I did not want to remove access for that role entirely; I only want to remove access in Kibana.
For this reason, I chose to change the Search UI permission check to check both that the role has the Manage Search UI permission AND the View Credentials permission.
All other roles should remain unaffected.
Here is a screenshot comparing 7.14 ent-search and kibana, note that Editors still have access in ent-search but not in Kibana:
Checklist
For maintainers