[Index pattern] Add support for composite runtime fields by sebelga · Pull Request #103879 · elastic/kibana

sebelga · 2021-06-30T13:08:18Z

This PR is the implementation of the #99462 discussion.

It is not yet possible to fully test this PR in Discover as ES does not support the object runtime field type. But once they do, I expect very few changes in this PR.

Currently if we navigate in Discover we don't see the subFields because they don't exist in the search response. And the parent object shows up in the list of fields because I temporarily hardcode it to the keyword type to avoid the search request to throw an error.

In the index pattern management we do see the subFields as they are added to the list from the runtimeFieldMap

sebelga · 2021-06-30T13:40:20Z

src/plugins/data/common/index_patterns/index_patterns/index_pattern.ts

This is not a breaking change as EnhancedRuntimeField has added prop (no prop has been removed or renamed)

sebelga · 2021-06-30T13:46:34Z

src/plugins/index_pattern_field_editor/public/open_delete_modal.tsx

We prevent deleting a subField directly as this will have to be done by editing the runtime composite script.

sebelga · 2021-06-30T13:47:03Z

src/plugins/index_pattern_field_editor/public/open_editor.tsx

We prevent editing a subField directly as this will have to be done by editing the runtime composite script.

sebelga · 2021-06-30T13:48:12Z

src/plugins/index_pattern_field_editor/public/open_editor.tsx

To keep consistency with ES we will always return an array, even if it is for one field created.

kibanamachine · 2021-08-26T12:56:41Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request
Commit: 5f1f3fb
Storybooks Preview
Pipeline Steps (look for red circles / failed steps)
Interpreting CI Failures

Failed CI Steps

Test Failures

Kibana Pipeline / jest / Jest Tests.src/plugins/data/common/index_patterns/index_patterns.IndexPattern toSpec should match snapshot

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has not failed recently on tracked branches

Stack Trace

Error: expect(received).toMatchSnapshot()

Snapshot name: `IndexPattern toSpec should match snapshot 1`

- Snapshot  - 1
+ Received  + 1

@@ -771,19 +771,19 @@
        "type": "date",
      },
    },
    "id": "test-pattern",
    "intervalName": undefined,
+   "runtimeCompositeMap": Object {},
    "runtimeFieldMap": Object {
      "runtime_field": Object {
        "script": Object {
          "source": "emit('hello world')",
        },
        "type": "keyword",
      },
    },
-   "runtimeObjectMap": Object {},
    "sourceFilters": undefined,
    "timeFieldName": "time",
    "title": "title",
    "type": "index-pattern",
    "typeMeta": undefined,
    at Object.<anonymous> (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/src/plugins/data/common/index_patterns/index_patterns/index_pattern.test.ts:296:37)
    at Object.asyncJestTest (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-jasmine2/build/jasmineAsyncInstall.js:106:37)
    at /var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-jasmine2/build/queueRunner.js:45:12
    at new Promise (<anonymous>)
    at mapper (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-jasmine2/build/queueRunner.js:28:19)
    at /var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-jasmine2/build/queueRunner.js:75:41
    at processTicksAndRejections (internal/process/task_queues.js:95:5)

Kibana Pipeline / jest / Jest Tests.src/plugins/data/common/index_patterns/index_patterns.IndexPatterns savedObjectToSpec

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has not failed recently on tracked branches

Stack Trace

Error: expect(received).toMatchSnapshot()

Snapshot name: `IndexPatterns savedObjectToSpec 1`

- Snapshot  - 0
+ Received  + 1

@@ -10,10 +10,11 @@
      "field": Object {},
    },
    "fields": Object {},
    "id": "id",
    "intervalName": undefined,
+   "runtimeCompositeMap": Object {},
    "runtimeFieldMap": Object {
      "aRuntimeField": Object {
        "script": Object {
          "source": "emit('hello')",
        },
    at Object.<anonymous> (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/src/plugins/data/common/index_patterns/index_patterns/index_patterns.test.ts:248:18)
    at Object.asyncJestTest (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-jasmine2/build/jasmineAsyncInstall.js:106:37)
    at /var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-jasmine2/build/queueRunner.js:45:12
    at new Promise (<anonymous>)
    at mapper (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-jasmine2/build/queueRunner.js:28:19)
    at /var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-jasmine2/build/queueRunner.js:75:41

Kibana Pipeline / jest / Jest Tests.src/plugins/discover/public/application/apps/main/components/sidebar.Discover IndexPattern Management renders correctly

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has not failed recently on tracked branches

Stack Trace

Error: expect(received).toMatchSnapshot()

Snapshot name: `Discover IndexPattern Management renders correctly 1`

- Snapshot  - 0
+ Received  + 1

@@ -659,10 +659,11 @@
          "_type",
          "_source",
        ],
        "originalSavedObjectBody": Object {},
        "resetOriginalSavedObjectBody": [Function],
+       "runtimeCompositeMap": Object {},
        "runtimeFieldMap": Object {},
        "setFieldFormat": [Function],
        "shortDotsEnable": false,
        "sourceFilters": undefined,
        "timeFieldName": "time",
    at Object.<anonymous> (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/src/plugins/discover/public/application/apps/main/components/sidebar/discover_index_pattern_management.test.tsx:71:23)
    at Object.asyncJestTest (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-jasmine2/build/jasmineAsyncInstall.js:106:37)
    at /var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-jasmine2/build/queueRunner.js:45:12
    at new Promise (<anonymous>)
    at mapper (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-jasmine2/build/queueRunner.js:28:19)
    at /var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-jasmine2/build/queueRunner.js:75:41
    at processTicksAndRejections (internal/process/task_queues.js:95:5)

and 3 more failures, only showing the first 3.

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`indexPatternFieldEditor`	264.6KB	267.3KB	+2.7KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`data`	775.6KB	779.3KB	+3.7KB
`indexPatternFieldEditor`	37.5KB	38.3KB	+777.0B
total			+4.5KB

History

💔 Build #148857 failed 9244923
💔 Build #148528 failed 0b3357d18e05560efd9a03755a82a69b3d1e5380
💔 Build #148258 failed fe00d868621e39ce20ff2a1e2f22c5eebbdd42e0
💔 Build #148244 failed feaa415c1d1c74fce2f0a055583e80a207e66243

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

sebelga · 2021-08-26T13:58:31Z

Closing in favour of #110226.

sebelga commented Jun 30, 2021

View reviewed changes

sebelga requested review from mattkime, ppisljar and stacey-gammon June 30, 2021 13:55

sebelga force-pushed the index-pattern-field-editor/object-runtime-fields branch from a197112 to fd89bb9 Compare August 23, 2021 10:01

sebelga changed the title ~~[Index pattern] Add support for object runtime fields~~ [Index pattern] Add support for composite runtime fields Aug 23, 2021

sebelga force-pushed the index-pattern-field-editor/object-runtime-fields branch from b250f58 to feaa415 Compare August 24, 2021 16:23

sebelga added 19 commits August 26, 2021 12:16

Add runtimeObject to indexPattern

5267c1c

Add parent param to IndexPatternField

7f7a02a

Block edit and delete of object subFields

911d36b

Handle computedRuntimeFields and computedRuntimeObjects

ddb3381

Refactor interface naming, using EnhancedRuntimeField for Kibana

052fc36

Cleanup

d45b188

Add comment for getComputedRuntimeObjects()

f8a3479

Don't allow saving runtime objects without subfields

3e0a9da

Fix TS issues

7911990

Update jest snapshot

8ed9c4c

Add "composite" option and update Preview to support it

6a77d9b

Refactor code to use "composite" instead of "object"

118b053

Update IndexPattern to handle composite runtime field

293193e

Update comments

3a2ff16

Update API docs

907d0e6

Fix FieldFormatConfig type

1f01add

Update API docs

8464882

Update indexPatternSpecSchema on server

50b05de

Fix component integration tests

9244923

sebelga force-pushed the index-pattern-field-editor/object-runtime-fields branch from 0b3357d to 9244923 Compare August 26, 2021 11:17

Update API docs

5f1f3fb

sebelga closed this Aug 26, 2021

sebelga deleted the index-pattern-field-editor/object-runtime-fields branch August 26, 2021 14:38

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Index pattern] Add support for composite runtime fields#103879

[Index pattern] Add support for composite runtime fields#103879
sebelga wants to merge 20 commits intoelastic:masterfrom
sebelga:index-pattern-field-editor/object-runtime-fields

sebelga commented Jun 30, 2021 •

edited

Loading

Uh oh!

sebelga Jun 30, 2021

Uh oh!

sebelga Jun 30, 2021 •

edited

Loading

Uh oh!

sebelga Jun 30, 2021 •

edited

Loading

Uh oh!

sebelga Jun 30, 2021

Uh oh!

kibanamachine commented Aug 26, 2021 •

edited

Loading

Standard Out

Stack Trace

Standard Out

Stack Trace

Standard Out

Stack Trace

Uh oh!

sebelga commented Aug 26, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

sebelga commented Jun 30, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sebelga Jun 30, 2021

Choose a reason for hiding this comment

Uh oh!

sebelga Jun 30, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sebelga Jun 30, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sebelga Jun 30, 2021

Choose a reason for hiding this comment

Uh oh!

kibanamachine commented Aug 26, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

💔 Build Failed

Failed CI Steps

Test Failures

Standard Out

Stack Trace

Standard Out

Stack Trace

Standard Out

Stack Trace

Metrics [docs]

Async chunks

Page load bundle

History

Uh oh!

sebelga commented Aug 26, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

sebelga commented Jun 30, 2021 •

edited

Loading

sebelga Jun 30, 2021 •

edited

Loading

sebelga Jun 30, 2021 •

edited

Loading

kibanamachine commented Aug 26, 2021 •

edited

Loading