Skip to content

Conversation

@snide
Copy link
Contributor

@snide snide commented Jun 30, 2021

Summary

Removes the add data button from the nav which didn't go anywhere. Was accidentally left in as part of #103192

@snide snide added v7.14.0 auto-backport Deprecated - use backport:version if exact versions are needed labels Jun 30, 2021
@snide snide requested a review from myasonik June 30, 2021 01:13
@snide snide requested a review from a team as a code owner June 30, 2021 01:13
@snide snide added the release_note:skip Skip the PR/issue when compiling release notes label Jun 30, 2021
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
core 418.1KB 417.4KB -624.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@snide snide merged commit 0ef5420 into elastic:master Jun 30, 2021
@snide snide deleted the fix/add_data_button branch June 30, 2021 11:47
@kibanamachine
Copy link
Contributor

💔 Backport failed

Status Branch Result
7.x Commit could not be cherrypicked due to conflicts

To backport manually run:
node scripts/backport --pr 103810

jloleysens added a commit to jloleysens/kibana that referenced this pull request Jun 30, 2021
…-policy-2

* 'master' of github.com:elastic/kibana:
  [Reporting] Reintroduce "ILM policy for managing reporting indices" (elastic#103850)
  [Security Solution][Endpoint] Allow activity log scrolling on small screens (elastic#103852)
  Allow zero (0) to unset unenroll_timeout field (elastic#103790)
  [TSVB] Metric count is depicted as `-` instead of 0 (elastic#103717)
  [Query] Es query/field base (elastic#103177)
  Remove add data button from nav (elastic#103810)
  Fix telemetry advanced setting style (elastic#103838)
  [Transform] Fix default naming and sorting fields suggestion for `top_metrics` agg (elastic#103690)
  [APM] use conventional error rate color for correlations (elastic#103500)

# Conflicts:
#	x-pack/plugins/reporting/server/lib/store/store.ts
jloleysens added a commit to jloleysens/kibana that referenced this pull request Jun 30, 2021
…-png-pdf-report-type

* 'master' of github.com:elastic/kibana: (178 commits)
  [test] Migrating to kbn_archiver from es_archiver - for the Maps app (elastic#103028)
  [Reporting] Reintroduce "ILM policy for managing reporting indices" (elastic#103850)
  [Security Solution][Endpoint] Allow activity log scrolling on small screens (elastic#103852)
  Allow zero (0) to unset unenroll_timeout field (elastic#103790)
  [TSVB] Metric count is depicted as `-` instead of 0 (elastic#103717)
  [Query] Es query/field base (elastic#103177)
  Remove add data button from nav (elastic#103810)
  Fix telemetry advanced setting style (elastic#103838)
  [Transform] Fix default naming and sorting fields suggestion for `top_metrics` agg (elastic#103690)
  [APM] use conventional error rate color for correlations (elastic#103500)
  Endpoint Telemetry: Agents Metrics + Policy Config / Response (elastic#102171)
  [Alerting] Fixed search results are not updated when search term is removed on Rules and Connectors page (elastic#103663)
  fix too many rernders (elastic#103672)
  [APM] Add “Analyze Data” button (elastic#103485)
  [Lens] Fix value popover spacing (elastic#103081)
  [TSVB] Fix TSVB is not reporting all categories of Elasticsearch error (elastic#102926)
  [SECURITY] Adds security links to doc link service (elastic#102676)
  Update dependency @elastic/charts to v31 (elastic#102078)
  [Security Solution][CTI] Investigation time enrichment UI (elastic#103383)
  Adds ECS guide to doc links service (elastic#102246)
  ...

# Conflicts:
#	x-pack/plugins/reporting/public/share_context_menu/register_pdf_png_reporting.tsx
snide added a commit to snide/kibana that referenced this pull request Jul 1, 2021
* Remove add data button from nav

* remove unused imports

Co-authored-by: Michail Yasonik <[email protected]>
# Conflicts:
#	src/core/public/chrome/ui/header/__snapshots__/collapsible_nav.test.tsx.snap
#	src/core/public/chrome/ui/header/collapsible_nav.tsx
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jul 2, 2021
@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

3 similar comments
@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jul 7, 2021
snide added a commit to snide/kibana that referenced this pull request Jul 8, 2021
* Remove add data button from nav

* remove unused imports

Co-authored-by: Michail Yasonik <[email protected]>
snide added a commit to snide/kibana that referenced this pull request Jul 8, 2021
* Remove add data button from nav

* remove unused imports

Co-authored-by: Michail Yasonik <[email protected]>
snide added a commit that referenced this pull request Jul 9, 2021
* Remove add data button from nav

* remove unused imports

Co-authored-by: Michail Yasonik <[email protected]>

Co-authored-by: Michail Yasonik <[email protected]>
snide added a commit that referenced this pull request Jul 9, 2021
* Remove add data button from nav

* remove unused imports

Co-authored-by: Michail Yasonik <[email protected]>

Co-authored-by: Michail Yasonik <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-backport Deprecated - use backport:version if exact versions are needed backported release_note:skip Skip the PR/issue when compiling release notes v7.14.0 v7.15.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants