Adjust Table component styles and markup to maintain fixed column widths, regardless of cell content.#10378
Merged
cjcenizal merged 2 commits intoFeb 16, 2017
Conversation
cjcenizal
force-pushed
the
bug/fixed-table-column-widths
branch
2 times, most recently
from
0e3b0bc to
3ea9cd4
Compare
…ths, regardless of cell content. - Fix ellipsis-truncation of text in IE11 and Edge. - Update Visualize landing table markup.
cjcenizal
force-pushed
the
bug/fixed-table-column-widths
branch
from
3ea9cd4 to
e423918
Compare
cjcenizal
added
Team:Platform-Design
Contributor
|
CSS is literally the most awful thing ever created by humans. LGTM |
Contributor
|
Actually, do you need to adjust the dashboard styles as well? The checkbox alignment looks good in visualize (and in the users/roles pr), but dashboard looks like this:
|
Contributor
Author
|
@epixa Great catch. Looks like I forgot to push a commit. |
Contributor
|
LGTM for real this time |
elastic-jasper
added a commit
that referenced
this pull request
Feb 16, 2017
…ths, regardless of cell content. Backports PR #10378 **Commit 1:** Adjust Table component styles and markup to maintain fixed column widths, regardless of cell content. - Fix ellipsis-truncation of text in IE11 and Edge. - Update Visualize landing table markup. * Original sha: e423918 * Authored by CJ Cenizal <cj@cenizal.com> on 2017-02-15T19:45:49Z **Commit 2:** Update Dashboard landing table and Saved Objects table with cell liner markup. * Original sha: 4e0f431 * Authored by CJ Cenizal <cj@cenizal.com> on 2017-02-15T19:55:33Z
elastic-jasper
added a commit
that referenced
this pull request
Feb 16, 2017
…ths, regardless of cell content. Backports PR #10378 **Commit 1:** Adjust Table component styles and markup to maintain fixed column widths, regardless of cell content. - Fix ellipsis-truncation of text in IE11 and Edge. - Update Visualize landing table markup. * Original sha: e423918 * Authored by CJ Cenizal <cj@cenizal.com> on 2017-02-15T19:45:49Z **Commit 2:** Update Dashboard landing table and Saved Objects table with cell liner markup. * Original sha: 4e0f431 * Authored by CJ Cenizal <cj@cenizal.com> on 2017-02-15T19:55:33Z
cjcenizal
pushed a commit
that referenced
this pull request
Feb 16, 2017
…ths, regardless of cell content. (#10401) Backports PR #10378 **Commit 1:** Adjust Table component styles and markup to maintain fixed column widths, regardless of cell content. - Fix ellipsis-truncation of text in IE11 and Edge. - Update Visualize landing table markup. * Original sha: e423918 * Authored by CJ Cenizal <cj@cenizal.com> on 2017-02-15T19:45:49Z **Commit 2:** Update Dashboard landing table and Saved Objects table with cell liner markup. * Original sha: 4e0f431 * Authored by CJ Cenizal <cj@cenizal.com> on 2017-02-15T19:55:33Z
cjcenizal
pushed a commit
that referenced
this pull request
Feb 16, 2017
…ths, regardless of cell content. (#10400) Backports PR #10378 **Commit 1:** Adjust Table component styles and markup to maintain fixed column widths, regardless of cell content. - Fix ellipsis-truncation of text in IE11 and Edge. - Update Visualize landing table markup. * Original sha: e423918 * Authored by CJ Cenizal <cj@cenizal.com> on 2017-02-15T19:45:49Z **Commit 2:** Update Dashboard landing table and Saved Objects table with cell liner markup. * Original sha: 4e0f431 * Authored by CJ Cenizal <cj@cenizal.com> on 2017-02-15T19:55:33Z
patrykkopycinski
pushed a commit
to patrykkopycinski/kibana
that referenced
this pull request
May 6, 2026
…ths, regardless of cell content. (elastic#10378) * Adjust Table component styles and markup to maintain fixed column widths, regardless of cell content. - Fix ellipsis-truncation of text in IE11 and Edge. - Update Visualize landing table markup. * Update Dashboard landing table and Saved Objects table with cell liner markup.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partially addresses #10283.
Browsers
Edge
IE11
OS X, Chrome
OS X, Safari
OS X, Firefox