[KibanaPageTemplate] Fix custom sidebar classes overriding kbnPageTemplate class#103715
Merged
cee-chen merged 6 commits intoelastic:masterfrom Jul 14, 2021
Merged
[KibanaPageTemplate] Fix custom sidebar classes overriding kbnPageTemplate class#103715cee-chen merged 6 commits intoelastic:masterfrom
cee-chen merged 6 commits intoelastic:masterfrom
Conversation
- due to it existing in ...rest, and ...rest coming after pageSideBarProps
cee-chen
commented
Jun 29, 2021
src/plugins/kibana_react/public/page_template/page_template.tsx
Outdated
Show resolved
Hide resolved
myasonik
approved these changes
Jun 29, 2021
Contributor
Author
|
@elastic/kibana-app-services Any chance one of y'all can take a quick look at this and approve as CODEOWNER? This should be a fairly small PR :) |
Contributor
Author
|
@elasticmachine run elasticsearch-ci/docs |
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
|
@elasticmachine merge upstream |
cchaos
suggested changes
Jul 12, 2021
src/plugins/kibana_react/public/page_template/page_template.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com>
Contributor
💛 Build succeeded, but was flaky
Test FailuresKibana Pipeline / general / Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/lens/heatmap·ts.lens app lens heatmap should reflect stop colors change on the chartStandard OutStack TraceMetrics [docs]Page load bundle
History
To update your PR or re-run it, just comment with: |
lukasolson
approved these changes
Jul 14, 2021
kibanamachine
added a commit
to kibanamachine/kibana
that referenced
this pull request
Jul 14, 2021
…plate class (elastic#103715) * Fix .kbnPageTemplate__pageSideBar getting overriden by passed classes - due to it existing in ...rest, and ...rest coming after pageSideBarProps * Add test * Fix `sideBarClasses` Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com>
Contributor
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
Contributor
Author
|
Thanks so much @lukasolson!! |
kibanamachine
added a commit
that referenced
this pull request
Jul 14, 2021
…plate class (#103715) (#105647) * Fix .kbnPageTemplate__pageSideBar getting overriden by passed classes - due to it existing in ...rest, and ...rest coming after pageSideBarProps * Add test * Fix `sideBarClasses` Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com> Co-authored-by: Constance <constancecchen@users.noreply.github.com> Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com>
2 tasks
kibanamachine
added a commit
to kibanamachine/kibana
that referenced
this pull request
Aug 11, 2021
…plate class (elastic#103715) * Fix .kbnPageTemplate__pageSideBar getting overriden by passed classes - due to it existing in ...rest, and ...rest coming after pageSideBarProps * Add test * Fix `sideBarClasses` Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com>
Contributor
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
kibanamachine
added a commit
that referenced
this pull request
Aug 11, 2021
…plate class (#103715) (#108234) * Fix .kbnPageTemplate__pageSideBar getting overriden by passed classes - due to it existing in ...rest, and ...rest coming after pageSideBarProps * Add test * Fix `sideBarClasses` Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com> Co-authored-by: Constance <constancecchen@users.noreply.github.com> Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
.kbnPageTemplate__pageSideBarCSS class was getting overridden by anyone passing a custompageSideBarProps={{ className: 'whatever' }}into KibanaPageTemplate. This PR should fix that!Before:
Missing class and styling:
After:
Checklist