Skip to content

Fix Safari bug: Safari ignores :enabled pseudo class, preventing button active and hover states from taking effect.#10369

Merged
cjcenizal merged 1 commit intoelastic:masterfrom
cjcenizal:bug/safari-button-states
Feb 16, 2017
Merged

Fix Safari bug: Safari ignores :enabled pseudo class, preventing button active and hover states from taking effect.#10369
cjcenizal merged 1 commit intoelastic:masterfrom
cjcenizal:bug/safari-button-states

Conversation

@cjcenizal
Copy link
Copy Markdown
Contributor

@cjcenizal cjcenizal commented Feb 15, 2017

Partially addresses #10283

the "Add" button in the table doesn't behave as the "Delete" does button when clicked. According to the UI framework guildelines.. buttons need to move one pixel down when click (as a "clicked feedback")... the Delete button does this, the "Add" button doesn't. Also, the "hover" style is different between the two - The "Delete" button changes bg color to a darker one, the "Add" button seems to change the ("+") text color to a darker one.

button-click

…on active and hover states from taking effect.
@cjcenizal cjcenizal added Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins. bug Fixes for quality problems that affect the customer experience v5.3.0 v5.4.0 v6.0.0 labels Feb 15, 2017
@epixa
Copy link
Copy Markdown
Contributor

epixa commented Feb 16, 2017

LGTM

@cjcenizal cjcenizal merged commit 408a2e6 into elastic:master Feb 16, 2017
@cjcenizal cjcenizal deleted the bug/safari-button-states branch February 16, 2017 16:16
elastic-jasper added a commit that referenced this pull request Feb 16, 2017
…on active and hover states from taking effect.

Backports PR #10369

**Commit 1:**
Fix Safari bug: Safari ignores :enabled pseudo class, preventing button active and hover states from taking effect.

* Original sha: 920ef6c
* Authored by CJ Cenizal <cj@cenizal.com> on 2017-02-15T16:49:34Z
cjcenizal pushed a commit that referenced this pull request Feb 16, 2017
…on active and hover states from taking effect. (#10398)

Backports PR #10369

**Commit 1:**
Fix Safari bug: Safari ignores :enabled pseudo class, preventing button active and hover states from taking effect.

* Original sha: 920ef6c
* Authored by CJ Cenizal <cj@cenizal.com> on 2017-02-15T16:49:34Z
elastic-jasper added a commit that referenced this pull request Feb 16, 2017
…on active and hover states from taking effect.

Backports PR #10369

**Commit 1:**
Fix Safari bug: Safari ignores :enabled pseudo class, preventing button active and hover states from taking effect.

* Original sha: 920ef6c
* Authored by CJ Cenizal <cj@cenizal.com> on 2017-02-15T16:49:34Z
cjcenizal pushed a commit that referenced this pull request Feb 16, 2017
…on active and hover states from taking effect. (#10399)

Backports PR #10369

**Commit 1:**
Fix Safari bug: Safari ignores :enabled pseudo class, preventing button active and hover states from taking effect.

* Original sha: 920ef6c
* Authored by CJ Cenizal <cj@cenizal.com> on 2017-02-15T16:49:34Z
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Fixes for quality problems that affect the customer experience Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins. v5.3.0 v5.4.0 v6.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants