Skip to content

[7.x] Sharing saved objects phase 3.5 (#100424)#103575

Merged
kibanamachine merged 1 commit intoelastic:7.xfrom
kibanamachine:backport/7.x/pr-100424
Jun 29, 2021
Merged

[7.x] Sharing saved objects phase 3.5 (#100424)#103575
kibanamachine merged 1 commit intoelastic:7.xfrom
kibanamachine:backport/7.x/pr-100424

Conversation

@kibanamachine
Copy link
Copy Markdown
Contributor

Backports the following commits to 7.x:

@kibanamachine kibanamachine added the backport This PR is a backport of another PR label Jun 28, 2021
@kibanamachine kibanamachine enabled auto-merge (squash) June 28, 2021 22:27
@kibanamachine
Copy link
Copy Markdown
Contributor Author

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
savedObjectsManagement 78 79 +1
spaces 249 251 +2
total +3

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
core 1055 1056 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
ml 5.9MB 5.9MB +9.0B
savedObjectsManagement 138.9KB 141.9KB +3.0KB
spaces 272.8KB 279.8KB +6.9KB
total +10.0KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
core 417.3KB 417.8KB +531.0B
spaces 41.7KB 42.4KB +712.0B
total +1.2KB

Saved Objects .kibana field count

Every field in each saved object type adds overhead to Elasticsearch. Kibana needs to keep the total field count below Elasticsearch's default limit of 1000 fields. Only specify field mappings for the fields you wish to search on or query. See https://www.elastic.co/guide/en/kibana/master/development-plugin-saved-objects.html#_mappings

id before after diff
legacy-url-alias 4 5 +1
Unknown metric groups

API count

id before after diff
core 2284 2296 +12
spaces 96 106 +10
spacesOss 71 72 +1
total +23

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @jportner

@kibanamachine kibanamachine merged commit 06313f3 into elastic:7.x Jun 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants