Skip to content

Fix condition when exportCount is 0#103573

Closed
TinaHeiligers wants to merge 1 commit intoelastic:masterfrom
TinaHeiligers:so-exports/fix_importing_excluded
Closed

Fix condition when exportCount is 0#103573
TinaHeiligers wants to merge 1 commit intoelastic:masterfrom
TinaHeiligers:so-exports/fix_importing_excluded

Conversation

@TinaHeiligers
Copy link
Contributor

@TinaHeiligers TinaHeiligers commented Jun 28, 2021 •
edited
Loading

Fixes #103517

Background:
It is possible to export an ndjson file that only contains "excluded" saved objects but we were throwing an Unhandled Promise rejection from createFilterStream. This PR fixes the condition.

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@TinaHeiligers TinaHeiligers added Team:Core Platform Core services: plugins, logging, config, saved objects, http, ES client, i18n, etc t// release_note:skip Skip the PR/issue when compiling release notes v7.14.0 labels Jun 28, 2021
@TinaHeiligers TinaHeiligers mentioned this pull request Jun 28, 2021
Closed
@TinaHeiligers
Copy link
Contributor Author

TinaHeiligers commented Jun 28, 2021 •
edited
Loading

We can close this if the fix in is in another PR.

@TinaHeiligers TinaHeiligers deleted the so-exports/fix_importing_excluded branch June 28, 2021 22:05
@TinaHeiligers TinaHeiligers restored the so-exports/fix_importing_excluded branch June 28, 2021 22:23
@TinaHeiligers TinaHeiligers reopened this Jun 28, 2021
@TinaHeiligers
Copy link
Contributor Author

TinaHeiligers commented Jun 28, 2021

Hot fix added in #102999

@kibanamachine
Copy link
Contributor

kibanamachine commented Jun 29, 2021

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@TinaHeiligers TinaHeiligers deleted the so-exports/fix_importing_excluded branch July 21, 2021 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

release_note:skip Skip the PR/issue when compiling release notes Team:Core Platform Core services: plugins, logging, config, saved objects, http, ES client, i18n, etc t// v7.14.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Error when importing a file with file containing only excluded saved objects

2 participants

@TinaHeiligers @kibanamachine