[build] Add notice file#10344
Merged
epixa merged 7 commits intoelastic:masterfrom Feb 16, 2017
Merged
Conversation
jbudz
commented
Feb 14, 2017
Contributor
Author
There was a problem hiding this comment.
this should probably be started from a base file, where we can include committed dependencies too
Contributor
|
I think this needs to include the contents of each dependency's license file as well, if it exists. Check out logstash builds for an example. |
jbudz
force-pushed
the
features/notice
branch
from
9b44ab9 to
844e9e6
Compare
jbudz
force-pushed
the
features/notice
branch
from
844e9e6 to
7cfa6bf
Compare
Contributor
|
As your comment mentioned, can you seed this from a base file that includes the header by default? Then the build step can add to it. |
Contributor
|
I'm tagging this with 5.3.0 since it's a really low risk change, though it's not a blocker. If we don't get it into 5.3.0, we can just ship it in 5.3.1. |
epixa
suggested changes
Feb 16, 2017
Contributor
epixa
left a comment
epixa
left a comment
There was a problem hiding this comment.
One minor change, then I think this is good to go.
| @@ -0,0 +1,59 @@ | |||
| Elasticsearch Kibana | |||
Contributor
There was a problem hiding this comment.
Just Kibana on the first line.
Contributor
|
LGTM |
epixa
approved these changes
Feb 16, 2017
epixa
pushed a commit
that referenced
this pull request
Feb 16, 2017
* [build] Add notice file * [build] Include license text if available * [build] Look for both license and notice files * [build] Add node license to notice * [build] Add a base notice file including info on committed dependencies * Bump license copyright year * [build] Kibana at top of notice
epixa
pushed a commit
that referenced
this pull request
Feb 16, 2017
* [build] Add notice file * [build] Include license text if available * [build] Look for both license and notice files * [build] Add node license to notice * [build] Add a base notice file including info on committed dependencies * Bump license copyright year * [build] Kibana at top of notice
epixa
pushed a commit
that referenced
this pull request
Feb 16, 2017
* [build] Add notice file * [build] Include license text if available * [build] Look for both license and notice files * [build] Add node license to notice * [build] Add a base notice file including info on committed dependencies * Bump license copyright year * [build] Kibana at top of notice
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a notice file to builds. Closes #9652.
To test:
npm run buildand look for NOTICE.txt at the root of an extracted package.