Skip to content

[App Search] Fix Engine Overview not properly stretching to full page height #103337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cee-chen merged 1 commit into from
Jun 24, 2021
Merged

[App Search] Fix Engine Overview not properly stretching to full page height #103337

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions ...search/public/applications/app_search/components/engine_overview/engine_overview.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,11 +29,6 @@ describe('EngineOverview', () => {
setMockValues(values);
});

it('renders', () => {
const wrapper = shallow(<EngineOverview />);
expect(wrapper.find('[data-test-subj="EngineOverview"]')).toHaveLength(1);
});

describe('EmptyEngineOverview', () => {
it('renders when the engine has no documents & the user can add documents', () => {
const myRole = { canManageEngineDocuments: true, canViewEngineCredentials: true };
Expand Down
6 changes: 1 addition & 5 deletions ...rise_search/public/applications/app_search/components/engine_overview/engine_overview.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,5 @@ export const EngineOverview: React.FC = () => {
const canAddDocuments = canManageEngineDocuments && canViewEngineCredentials;
const showEngineOverview = !isEngineEmpty || !canAddDocuments || isMetaEngine;

return (
<div data-test-subj="EngineOverview">
{showEngineOverview ? <EngineOverviewMetrics /> : <EmptyEngineOverview />}
</div>
);
return showEngineOverview ? <EngineOverviewMetrics /> : <EmptyEngineOverview />;
};
1 change: 1 addition & 0 deletions ...earch/public/applications/app_search/components/engine_overview/engine_overview_empty.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ export const EmptyEngineOverview: React.FC = () => {
</EuiButton>,
],
}}
data-test-subj="EngineOverview"
>
<DocumentCreationButtons />
<DocumentCreationFlyout />
Expand Down
1 change: 1 addition & 0 deletions ...rch/public/applications/app_search/components/engine_overview/engine_overview_metrics.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ export const EngineOverviewMetrics: React.FC = () => {
}),
}}
isLoading={dataLoading}
data-test-subj="EngineOverview"
>
<EuiFlexGroup>
<EuiFlexItem grow={1}>
Expand Down