Skip to content

[7.x] [App Search] Convert Search UI view to new page template + minor UI polish (#102813)#102952

Merged
kibanamachine merged 1 commit intoelastic:7.xfrom
kibanamachine:backport/7.x/pr-102813
Jun 22, 2021
Merged

[7.x] [App Search] Convert Search UI view to new page template + minor UI polish (#102813)#102952
kibanamachine merged 1 commit intoelastic:7.xfrom
kibanamachine:backport/7.x/pr-102813

Conversation

@kibanamachine
Copy link
Contributor

Backports the following commits to 7.x:

…olish (elastic#102813)

* Convert Search UI view to use new page template

+ update tests TODO

* [UX polish] Add empty state to Search UI view

- On a totally new engine, all pages except this one* had an empty state, so per Davey's recommendations I whipped up a new empty state for this page

* Overview has a custom 'empty' state, analytics does not have an empty state

* Update router

* Fix bad merge conflict resolution

* [Polish] Copy feedback proposed by Davey

- see elastic@cbc3706
@kibanamachine
Copy link
Contributor Author

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
enterpriseSearch 1450 1451 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
enterpriseSearch 2.1MB 2.1MB +909.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @constancecchen

@kibanamachine kibanamachine merged commit ba736fc into elastic:7.x Jun 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants