[App Search] Convert Curations pages to new page template by cee-chen · Pull Request #102835 · elastic/kibana

cee-chen · 2021-06-21T23:45:03Z

Summary

Follow up to #102170 - converts more App Search pages to the new KibanaPageTemplate. I'm attempting to break up the AS layout conversion into smaller, easier to review chunks.

This PR handles the Curation views (+ bonus small copy changes from Davey). As always, follow along by commit (and turn off whitespace diffs)

Screencaps

New empty state:

Checklist

Unit or functional tests were updated or added to match the most common scenarios
Any UI touched in this PR is usable by keyboard only (learn more about keyboard accessibility)
Any UI touched in this PR does not create any new axe failures (run axe in browser: FF, Chrome)
This renders correctly on smaller devices using a responsive layout. (You can test this in your browser)
This was checked for cross-browser compatibility

- Remove breadcrumbs set in router (will get set by page template) - Set up a curation breadcrumb helper for DRYness - Remove NotFound route - curation ID 404 handling will be used instead

+ move Empty State from table to top level

+ remove breadcrumb prop

- see https://github.com/elastic/kibana/pull/101958/files - Per https://elastic.github.io/eui/#/guidelines/writing we shouldn't be using "new", so I removed that also

- To match other create buttons across app

kibanamachine · 2021-06-23T00:34:47Z

💛 Build succeeded, but was flaky

continuous-integration/kibana-ci/pull-request
Commit: 21a3991
Storybooks Preview
Flaky suites:
- xpack-accessibility

Test Failures

Kibana Pipeline / general / X-Pack Accessibility Tests.x-pack/test/accessibility/apps/spaces·ts.Kibana spaces page meets a11y validations a11y test for space selection page

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has failed 2 times on tracked branches: https://github.com/elastic/kibana/issues/100968

[00:00:00]       │
[00:02:14]         └-: Kibana spaces page meets a11y validations
[00:02:14]           └-> "before all" hook for "a11y test for manage spaces menu from top nav on Kibana home"
[00:02:14]           └-> "before all" hook for "a11y test for manage spaces menu from top nav on Kibana home"
[00:02:14]             │ info [x-pack/test/functional/es_archives/empty_kibana] Loading "mappings.json"
[00:02:14]             │ info [o.e.c.m.MetadataDeleteIndexService] [kibana-ci-immutable-centos-tests-xxl-1624400956489088048] [.kibana_task_manager_8.0.0_001/cQZ2OIHuSEeE2uuau72mLQ] deleting index
[00:02:14]             │ info [o.e.c.m.MetadataDeleteIndexService] [kibana-ci-immutable-centos-tests-xxl-1624400956489088048] [.kibana_8.0.0_001/NqQFTSN8S-SUHfY8SeVL-A] deleting index
[00:02:14]             │ info [o.e.c.m.MetadataDeleteIndexService] [kibana-ci-immutable-centos-tests-xxl-1624400956489088048] [.kibana_1/-VjCDC9zSti_D4pIcbTNjA] deleting index
[00:02:14]             │ info [x-pack/test/functional/es_archives/empty_kibana] Deleted existing index ".kibana_8.0.0_001"
[00:02:14]             │ info [x-pack/test/functional/es_archives/empty_kibana] Deleted existing index ".kibana_task_manager_8.0.0_001"
[00:02:14]             │ info [x-pack/test/functional/es_archives/empty_kibana] Deleted existing index ".kibana_1"
[00:02:14]             │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-centos-tests-xxl-1624400956489088048] [.kibana_1] creating index, cause [api], templates [], shards [1]/[1]
[00:02:14]             │ info [x-pack/test/functional/es_archives/empty_kibana] Created index ".kibana_1"
[00:02:14]             │ debg [x-pack/test/functional/es_archives/empty_kibana] ".kibana_1" settings {"index":{"number_of_replicas":"1","number_of_shards":"1"}}
[00:02:14]             │ debg Migrating saved objects
[00:02:14]             │ proc [kibana]   log   [22:55:40.728] [info][savedobjects-service] [.kibana_task_manager] INIT -> CREATE_NEW_TARGET. took: 9ms.
[00:02:14]             │ proc [kibana]   log   [22:55:40.731] [info][savedobjects-service] [.kibana] INIT -> WAIT_FOR_YELLOW_SOURCE. took: 16ms.
[00:02:14]             │ proc [kibana]   log   [22:55:40.736] [info][savedobjects-service] [.kibana] WAIT_FOR_YELLOW_SOURCE -> SET_SOURCE_WRITE_BLOCK. took: 5ms.
[00:02:14]             │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-centos-tests-xxl-1624400956489088048] [.kibana_task_manager_8.0.0_001] creating index, cause [api], templates [], shards [1]/[1]
[00:02:14]             │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-centos-tests-xxl-1624400956489088048] updating number_of_replicas to [0] for indices [.kibana_task_manager_8.0.0_001]
[00:02:14]             │ info [o.e.c.m.MetadataIndexStateService] [kibana-ci-immutable-centos-tests-xxl-1624400956489088048] adding block write to indices [[.kibana_1/3EwlK593T1uXb4rSFM5Bmw]]
[00:02:14]             │ info [o.e.c.m.MetadataIndexStateService] [kibana-ci-immutable-centos-tests-xxl-1624400956489088048] completed adding block write to indices [.kibana_1]
[00:02:14]             │ proc [kibana]   log   [22:55:40.870] [info][savedobjects-service] [.kibana_task_manager] CREATE_NEW_TARGET -> MARK_VERSION_INDEX_READY. took: 142ms.
[00:02:14]             │ proc [kibana]   log   [22:55:40.897] [info][savedobjects-service] [.kibana] SET_SOURCE_WRITE_BLOCK -> CREATE_REINDEX_TEMP. took: 161ms.
[00:02:14]             │ proc [kibana]   log   [22:55:40.923] [info][savedobjects-service] [.kibana_task_manager] MARK_VERSION_INDEX_READY -> DONE. took: 53ms.
[00:02:14]             │ proc [kibana]   log   [22:55:40.924] [info][savedobjects-service] [.kibana_task_manager] Migration completed after 205ms
[00:02:14]             │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-centos-tests-xxl-1624400956489088048] [.kibana_8.0.0_reindex_temp] creating index, cause [api], templates [], shards [1]/[1]
[00:02:14]             │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-centos-tests-xxl-1624400956489088048] updating number_of_replicas to [0] for indices [.kibana_8.0.0_reindex_temp]
[00:02:14]             │ proc [kibana]   log   [22:55:41.012] [info][savedobjects-service] [.kibana] CREATE_REINDEX_TEMP -> REINDEX_SOURCE_TO_TEMP_OPEN_PIT. took: 115ms.
[00:02:14]             │ proc [kibana]   log   [22:55:41.016] [info][savedobjects-service] [.kibana] REINDEX_SOURCE_TO_TEMP_OPEN_PIT -> REINDEX_SOURCE_TO_TEMP_READ. took: 4ms.
[00:02:14]             │ proc [kibana]   log   [22:55:41.023] [info][savedobjects-service] [.kibana] REINDEX_SOURCE_TO_TEMP_READ -> REINDEX_SOURCE_TO_TEMP_CLOSE_PIT. took: 7ms.
[00:02:14]             │ proc [kibana]   log   [22:55:41.027] [info][savedobjects-service] [.kibana] REINDEX_SOURCE_TO_TEMP_CLOSE_PIT -> SET_TEMP_WRITE_BLOCK. took: 4ms.
[00:02:14]             │ info [o.e.c.m.MetadataIndexStateService] [kibana-ci-immutable-centos-tests-xxl-1624400956489088048] adding block write to indices [[.kibana_8.0.0_reindex_temp/ILaC6kSbS0mGtYysUA3tBQ]]
[00:02:14]             │ info [o.e.c.m.MetadataIndexStateService] [kibana-ci-immutable-centos-tests-xxl-1624400956489088048] completed adding block write to indices [.kibana_8.0.0_reindex_temp]
[00:02:14]             │ proc [kibana]   log   [22:55:41.110] [info][savedobjects-service] [.kibana] SET_TEMP_WRITE_BLOCK -> CLONE_TEMP_TO_TARGET. took: 83ms.
[00:02:14]             │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-centos-tests-xxl-1624400956489088048] applying create index request using existing index [.kibana_8.0.0_reindex_temp] metadata
[00:02:14]             │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-centos-tests-xxl-1624400956489088048] [.kibana_8.0.0_001] creating index, cause [clone_index], templates [], shards [1]/[1]
[00:02:14]             │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-centos-tests-xxl-1624400956489088048] updating number_of_replicas to [0] for indices [.kibana_8.0.0_001]
[00:02:15]             │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-centos-tests-xxl-1624400956489088048] [.kibana_8.0.0_001/TcLrwgM-QvydgKMUX9BF4Q] create_mapping
[00:02:15]             │ proc [kibana]   log   [22:55:41.251] [info][savedobjects-service] [.kibana] CLONE_TEMP_TO_TARGET -> REFRESH_TARGET. took: 141ms.
[00:02:15]             │ proc [kibana]   log   [22:55:41.256] [info][savedobjects-service] [.kibana] REFRESH_TARGET -> OUTDATED_DOCUMENTS_SEARCH_OPEN_PIT. took: 5ms.
[00:02:15]             │ proc [kibana]   log   [22:55:41.269] [info][savedobjects-service] [.kibana] OUTDATED_DOCUMENTS_SEARCH_OPEN_PIT -> OUTDATED_DOCUMENTS_SEARCH_READ. took: 13ms.
[00:02:15]             │ proc [kibana]   log   [22:55:41.277] [info][savedobjects-service] [.kibana] OUTDATED_DOCUMENTS_SEARCH_READ -> OUTDATED_DOCUMENTS_SEARCH_CLOSE_PIT. took: 8ms.
[00:02:15]             │ proc [kibana]   log   [22:55:41.280] [info][savedobjects-service] [.kibana] OUTDATED_DOCUMENTS_SEARCH_CLOSE_PIT -> UPDATE_TARGET_MAPPINGS. took: 3ms.
[00:02:15]             │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-centos-tests-xxl-1624400956489088048] [.kibana_8.0.0_001/TcLrwgM-QvydgKMUX9BF4Q] update_mapping [_doc]
[00:02:15]             │ proc [kibana]   log   [22:55:41.354] [info][savedobjects-service] [.kibana] UPDATE_TARGET_MAPPINGS -> UPDATE_TARGET_MAPPINGS_WAIT_FOR_TASK. took: 74ms.
[00:02:15]             │ info [o.e.t.LoggingTaskListener] [kibana-ci-immutable-centos-tests-xxl-1624400956489088048] 8160 finished with response BulkByScrollResponse[took=8.7ms,timed_out=false,sliceId=null,updated=0,created=0,deleted=0,batches=0,versionConflicts=0,noops=0,retries=0,throttledUntil=0s,bulk_failures=[],search_failures=[]]
[00:02:15]             │ proc [kibana]   log   [22:55:41.461] [info][savedobjects-service] [.kibana] UPDATE_TARGET_MAPPINGS_WAIT_FOR_TASK -> MARK_VERSION_INDEX_READY. took: 107ms.
[00:02:15]             │ info [o.e.c.m.MetadataDeleteIndexService] [kibana-ci-immutable-centos-tests-xxl-1624400956489088048] [.kibana_8.0.0_reindex_temp/ILaC6kSbS0mGtYysUA3tBQ] deleting index
[00:02:15]             │ proc [kibana]   log   [22:55:41.534] [info][savedobjects-service] [.kibana] MARK_VERSION_INDEX_READY -> DONE. took: 73ms.
[00:02:15]             │ proc [kibana]   log   [22:55:41.535] [info][savedobjects-service] [.kibana] Migration completed after 820ms
[00:02:15]             │ debg [x-pack/test/functional/es_archives/empty_kibana] Migrated Kibana index after loading Kibana data
[00:02:16]             │ debg [x-pack/test/functional/es_archives/empty_kibana] Ensured that default space exists in .kibana
[00:02:16]             │ debg applying update to kibana config: {"accessibility:disableAnimations":true,"dateFormat:tz":"UTC","visualization:visualize:legacyChartsLibrary":true}
[00:02:16]             │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-centos-tests-xxl-1624400956489088048] [.kibana_8.0.0_001/TcLrwgM-QvydgKMUX9BF4Q] update_mapping [_doc]
[00:02:18]             │ debg navigating to home url: http://localhost:61171/app/home#/
[00:02:18]             │ debg navigate to: http://localhost:61171/app/home#/
[00:02:18]             │ debg browser[INFO] http://localhost:61171/app/home?_t=1624402544200#/ 281 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:02:18]             │
[00:02:18]             │ debg browser[INFO] http://localhost:61171/bootstrap.js 41:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:02:18]             │ debg ... sleep(700) start
[00:02:19]             │ debg ... sleep(700) end
[00:02:19]             │ debg returned from get, calling refresh
[00:02:19]             │ debg browser[INFO] http://localhost:61171/app/home?_t=1624402544200#/ 281 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:02:19]             │
[00:02:19]             │ debg browser[INFO] http://localhost:61171/bootstrap.js 41:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:02:19]             │ debg currentUrl = http://localhost:61171/app/home#/
[00:02:19]             │          appUrl = http://localhost:61171/app/home#/
[00:02:19]             │ debg TestSubjects.find(kibanaChrome)
[00:02:19]             │ debg Find.findByCssSelector('[data-test-subj="kibanaChrome"]') with timeout=60000
[00:02:21]             │ debg ... sleep(501) start
[00:02:21]             │ debg ... sleep(501) end
[00:02:21]             │ debg in navigateTo url = http://localhost:61171/app/home#/
[00:02:21]           └-> a11y test for manage spaces menu from top nav on Kibana home
[00:02:21]             └-> "before each" hook: global before each for "a11y test for manage spaces menu from top nav on Kibana home"
[00:02:21]             │ debg TestSubjects.click(space-avatar-default)
[00:02:21]             │ debg Find.clickByCssSelector('[data-test-subj="space-avatar-default"]') with timeout=10000
[00:02:21]             │ debg Find.findByCssSelector('[data-test-subj="space-avatar-default"]') with timeout=10000
[00:02:21]             │ debg Waiting up to 20000ms for Manage spaces option visible...
[00:02:21]             │ debg TestSubjects.exists(manageSpaces)
[00:02:21]             │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="manageSpaces"]') with timeout=2500
[00:02:22]             │ debg --- retry.tryForTime error: stale element reference: element is not attached to the page document
[00:02:22]             │        (Session info: headless chrome=91.0.4472.114)
[00:02:23]             └- ✓ pass  (1.3s) "Kibana spaces page meets a11y validations a11y test for manage spaces menu from top nav on Kibana home"
[00:02:23]           └-> a11y test for manage spaces page
[00:02:23]             └-> "before each" hook: global before each for "a11y test for manage spaces page"
[00:02:23]             │ debg TestSubjects.click(manageSpaces)
[00:02:23]             │ debg Find.clickByCssSelector('[data-test-subj="manageSpaces"]') with timeout=10000
[00:02:23]             │ debg Find.findByCssSelector('[data-test-subj="manageSpaces"]') with timeout=10000
[00:02:23]             │ debg isGlobalLoadingIndicatorVisible
[00:02:23]             │ debg TestSubjects.exists(globalLoadingIndicator)
[00:02:23]             │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="globalLoadingIndicator"]') with timeout=1500
[00:02:24]             │ debg --- retry.tryForTime error: [data-test-subj="globalLoadingIndicator"] is not displayed
[00:02:25]             │ debg TestSubjects.exists(globalLoadingIndicator-hidden)
[00:02:25]             │ debg Find.existsByCssSelector('[data-test-subj="globalLoadingIndicator-hidden"]') with timeout=100000
[00:02:25]             │ debg TestSubjects.find(globalToastList)
[00:02:25]             │ debg Find.findByCssSelector('[data-test-subj="globalToastList"]') with timeout=10000
[00:02:35]             │ debg Waiting up to 20000ms for Manage spaces page visible...
[00:02:35]             │ debg TestSubjects.exists(createSpace)
[00:02:35]             │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="createSpace"]') with timeout=2500
[00:02:35]             └- ✓ pass  (12.6s) "Kibana spaces page meets a11y validations a11y test for manage spaces page"
[00:02:35]           └-> a11y test for click on create space page
[00:02:35]             └-> "before each" hook: global before each for "a11y test for click on create space page"
[00:02:35]             │ debg TestSubjects.click(createSpace)
[00:02:35]             │ debg Find.clickByCssSelector('[data-test-subj="createSpace"]') with timeout=10000
[00:02:35]             │ debg Find.findByCssSelector('[data-test-subj="createSpace"]') with timeout=10000
[00:02:36]             └- ✓ pass  (450ms) "Kibana spaces page meets a11y validations a11y test for click on create space page"
[00:02:36]           └-> a11y test for for customize space card
[00:02:36]             └-> "before each" hook: global before each for "a11y test for for customize space card"
[00:02:36]             │ debg TestSubjects.click(addSpaceName)
[00:02:36]             │ debg Find.clickByCssSelector('[data-test-subj="addSpaceName"]') with timeout=10000
[00:02:36]             │ debg Find.findByCssSelector('[data-test-subj="addSpaceName"]') with timeout=10000
[00:02:36]             │ debg TestSubjects.setValue(addSpaceName, space_a)
[00:02:36]             │ debg TestSubjects.click(addSpaceName)
[00:02:36]             │ debg Find.clickByCssSelector('[data-test-subj="addSpaceName"]') with timeout=10000
[00:02:36]             │ debg Find.findByCssSelector('[data-test-subj="addSpaceName"]') with timeout=10000
[00:02:36]             │ debg TestSubjects.click(space-avatar-space_a)
[00:02:36]             │ debg Find.clickByCssSelector('[data-test-subj="space-avatar-space_a"]') with timeout=10000
[00:02:36]             │ debg Find.findByCssSelector('[data-test-subj="space-avatar-space_a"]') with timeout=10000
[00:02:37]             └- ✓ pass  (976ms) "Kibana spaces page meets a11y validations a11y test for for customize space card"
[00:02:37]           └-> a11y test for color picker
[00:02:37]           └-> a11y test for customize and reset space URL identifier
[00:02:37]             └-> "before each" hook: global before each for "a11y test for customize and reset space URL identifier"
[00:02:37]             │ debg TestSubjects.click(CustomizeOrReset)
[00:02:37]             │ debg Find.clickByCssSelector('[data-test-subj="CustomizeOrReset"]') with timeout=10000
[00:02:37]             │ debg Find.findByCssSelector('[data-test-subj="CustomizeOrReset"]') with timeout=10000
[00:02:37]             │ debg TestSubjects.click(CustomizeOrReset)
[00:02:37]             │ debg Find.clickByCssSelector('[data-test-subj="CustomizeOrReset"]') with timeout=10000
[00:02:37]             │ debg Find.findByCssSelector('[data-test-subj="CustomizeOrReset"]') with timeout=10000
[00:02:38]             └- ✓ pass  (1.3s) "Kibana spaces page meets a11y validations a11y test for customize and reset space URL identifier"
[00:02:38]           └-> a11y test for describe space text space
[00:02:38]             └-> "before each" hook: global before each for "a11y test for describe space text space"
[00:02:38]             │ debg TestSubjects.click(descriptionSpaceText)
[00:02:38]             │ debg Find.clickByCssSelector('[data-test-subj="descriptionSpaceText"]') with timeout=10000
[00:02:38]             │ debg Find.findByCssSelector('[data-test-subj="descriptionSpaceText"]') with timeout=10000
[00:02:39]             └- ✓ pass  (576ms) "Kibana spaces page meets a11y validations a11y test for describe space text space"
[00:02:39]           └-> a11y test for toggling an entire feature category
[00:02:39]             └-> "before each" hook: global before each for "a11y test for toggling an entire feature category"
[00:02:39]             │ debg TestSubjects.click(featureCategoryButton_kibana)
[00:02:39]             │ debg Find.clickByCssSelector('[data-test-subj="featureCategoryButton_kibana"]') with timeout=10000
[00:02:39]             │ debg Find.findByCssSelector('[data-test-subj="featureCategoryButton_kibana"]') with timeout=10000
[00:02:39]             │ debg Find.findByCssSelector('button[aria-controls=featureCategory_kibana]') with timeout=10000
[00:02:40]             │ debg TestSubjects.click(featureCategoryButton_kibana)
[00:02:40]             │ debg Find.clickByCssSelector('[data-test-subj="featureCategoryButton_kibana"]') with timeout=10000
[00:02:40]             │ debg Find.findByCssSelector('[data-test-subj="featureCategoryButton_kibana"]') with timeout=10000
[00:02:40]             └- ✓ pass  (1.2s) "Kibana spaces page meets a11y validations a11y test for toggling an entire feature category"
[00:02:40]           └-> a11y test for space listing page
[00:02:40]             └-> "before each" hook: global before each for "a11y test for space listing page"
[00:02:40]             │ debg TestSubjects.click(save-space-button)
[00:02:40]             │ debg Find.clickByCssSelector('[data-test-subj="save-space-button"]') with timeout=10000
[00:02:40]             │ debg Find.findByCssSelector('[data-test-subj="save-space-button"]') with timeout=10000
[00:02:40]             │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-centos-tests-xxl-1624400956489088048] [.kibana_8.0.0_001/TcLrwgM-QvydgKMUX9BF4Q] update_mapping [_doc]
[00:02:40]             └- ✓ pass  (577ms) "Kibana spaces page meets a11y validations a11y test for space listing page"
[00:02:40]           └-> a11y test for updating a space
[00:02:40]             └-> "before each" hook: global before each for "a11y test for updating a space"
[00:02:40]             │ debg TestSubjects.click(space_a-editSpace)
[00:02:40]             │ debg Find.clickByCssSelector('[data-test-subj="space_a-editSpace"]') with timeout=10000
[00:02:40]             │ debg Find.findByCssSelector('[data-test-subj="space_a-editSpace"]') with timeout=10000
[00:02:41]             │ debg TestSubjects.click(cancel-space-button)
[00:02:41]             │ debg Find.clickByCssSelector('[data-test-subj="cancel-space-button"]') with timeout=10000
[00:02:41]             │ debg Find.findByCssSelector('[data-test-subj="cancel-space-button"]') with timeout=10000
[00:02:41]             └- ✓ pass  (1.0s) "Kibana spaces page meets a11y validations a11y test for updating a space"
[00:02:41]           └-> a11y test for delete space button
[00:02:41]             └-> "before each" hook: global before each for "a11y test for delete space button"
[00:02:41]             │ debg TestSubjects.click(createSpace)
[00:02:41]             │ debg Find.clickByCssSelector('[data-test-subj="createSpace"]') with timeout=10000
[00:02:41]             │ debg Find.findByCssSelector('[data-test-subj="createSpace"]') with timeout=10000
[00:02:41]             │ debg TestSubjects.click(addSpaceName)
[00:02:41]             │ debg Find.clickByCssSelector('[data-test-subj="addSpaceName"]') with timeout=10000
[00:02:41]             │ debg Find.findByCssSelector('[data-test-subj="addSpaceName"]') with timeout=10000
[00:02:42]             │ debg TestSubjects.setValue(addSpaceName, space_b)
[00:02:42]             │ debg TestSubjects.click(addSpaceName)
[00:02:42]             │ debg Find.clickByCssSelector('[data-test-subj="addSpaceName"]') with timeout=10000
[00:02:42]             │ debg Find.findByCssSelector('[data-test-subj="addSpaceName"]') with timeout=10000
[00:02:42]             │ debg TestSubjects.click(save-space-button)
[00:02:42]             │ debg Find.clickByCssSelector('[data-test-subj="save-space-button"]') with timeout=10000
[00:02:42]             │ debg Find.findByCssSelector('[data-test-subj="save-space-button"]') with timeout=10000
[00:02:42]             │ debg navigating to home url: http://localhost:61171/app/home#/
[00:02:42]             │ debg navigate to: http://localhost:61171/app/home#/
[00:02:42]             │ debg browser[INFO] http://localhost:61171/app/home?_t=1624402568530#/ 281 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:02:42]             │
[00:02:42]             │ debg browser[INFO] http://localhost:61171/bootstrap.js 41:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:02:42]             │ debg ... sleep(700) start
[00:02:43]             │ debg ... sleep(700) end
[00:02:43]             │ debg returned from get, calling refresh
[00:02:44]             │ debg browser[INFO] http://localhost:61171/app/home?_t=1624402568530#/ 281 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:02:44]             │
[00:02:44]             │ debg browser[INFO] http://localhost:61171/bootstrap.js 41:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:02:45]             │ debg currentUrl = http://localhost:61171/app/home#/
[00:02:45]             │          appUrl = http://localhost:61171/app/home#/
[00:02:45]             │ debg TestSubjects.find(kibanaChrome)
[00:02:45]             │ debg Find.findByCssSelector('[data-test-subj="kibanaChrome"]') with timeout=60000
[00:02:45]             │ debg ... sleep(501) start
[00:02:46]             │ debg ... sleep(501) end
[00:02:46]             │ debg in navigateTo url = http://localhost:61171/app/home#/
[00:02:46]             │ debg openSpacesNav()
[00:02:46]             │ debg TestSubjects.click(spacesNavSelector)
[00:02:46]             │ debg Find.clickByCssSelector('[data-test-subj="spacesNavSelector"]') with timeout=10000
[00:02:46]             │ debg Find.findByCssSelector('[data-test-subj="spacesNavSelector"]') with timeout=10000
[00:02:46]             │ info SpaceSelectorPage:clickSpaceAvatar(space_b)
[00:02:46]             │ debg TestSubjects.click(space-avatar-space_b)
[00:02:46]             │ debg Find.clickByCssSelector('[data-test-subj="space-avatar-space_b"]') with timeout=10000
[00:02:46]             │ debg Find.findByCssSelector('[data-test-subj="space-avatar-space_b"]') with timeout=10000
[00:02:47]             │ debg ... sleep(1000) start
[00:02:47]             │ debg browser[INFO] http://localhost:61171/s/space_b/app/home 281 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:02:47]             │
[00:02:47]             │ debg browser[INFO] http://localhost:61171/s/space_b/bootstrap.js 41:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:02:48]             │ debg ... sleep(1000) end
[00:02:48]             │ debg isGlobalLoadingIndicatorVisible
[00:02:48]             │ debg TestSubjects.exists(globalLoadingIndicator)
[00:02:48]             │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="globalLoadingIndicator"]') with timeout=1500
[00:02:50]             │ debg --- retry.tryForTime error: [data-test-subj="globalLoadingIndicator"] is not displayed
[00:02:50]             │ debg TestSubjects.exists(globalLoadingIndicator-hidden)
[00:02:50]             │ debg Find.existsByCssSelector('[data-test-subj="globalLoadingIndicator-hidden"]') with timeout=100000
[00:02:50]             │ debg openSpacesNav()
[00:02:50]             │ debg TestSubjects.click(spacesNavSelector)
[00:02:50]             │ debg Find.clickByCssSelector('[data-test-subj="spacesNavSelector"]') with timeout=10000
[00:02:50]             │ debg Find.findByCssSelector('[data-test-subj="spacesNavSelector"]') with timeout=10000
[00:02:50]             │ debg TestSubjects.click(manageSpaces)
[00:02:50]             │ debg Find.clickByCssSelector('[data-test-subj="manageSpaces"]') with timeout=10000
[00:02:50]             │ debg Find.findByCssSelector('[data-test-subj="manageSpaces"]') with timeout=10000
[00:02:50]             │ debg TestSubjects.click(space_b-deleteSpace)
[00:02:50]             │ debg Find.clickByCssSelector('[data-test-subj="space_b-deleteSpace"]') with timeout=10000
[00:02:50]             │ debg Find.findByCssSelector('[data-test-subj="space_b-deleteSpace"]') with timeout=10000
[00:02:51]             └- ✓ pass  (10.1s) "Kibana spaces page meets a11y validations a11y test for delete space button"
[00:02:51]           └-> a11y test for space selection page
[00:02:51]             └-> "before each" hook: global before each for "a11y test for space selection page"
[00:02:51]             │ debg TestSubjects.click(confirmModalConfirmButton)
[00:02:51]             │ debg Find.clickByCssSelector('[data-test-subj="confirmModalConfirmButton"]') with timeout=10000
[00:02:51]             │ debg Find.findByCssSelector('[data-test-subj="confirmModalConfirmButton"]') with timeout=10000
[00:02:52]             │ info Taking screenshot "/dev/shm/workspace/parallel/17/kibana/x-pack/test/functional/screenshots/failure/Kibana spaces page meets a11y validations a11y test for space selection page.png"
[00:02:52]             │ debg browser[INFO] http://localhost:61171/spaces/space_selector 281 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:02:52]             │
[00:02:52]             │ debg browser[INFO] http://localhost:61171/bootstrap.js 41:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:02:52]             │ info Current URL is: http://localhost:61171/spaces/space_selector
[00:02:53]             │ info Saving page source to: /dev/shm/workspace/parallel/17/kibana/x-pack/test/functional/failure_debug/html/Kibana spaces page meets a11y validations a11y test for space selection page.html
[00:02:53]             └- ✖ fail: Kibana spaces page meets a11y validations a11y test for space selection page
[00:02:53]             │      JavascriptError: javascript error: document unloaded while waiting for result
[00:02:53]             │   (Session info: headless chrome=91.0.4472.114)
[00:02:53]             │       at Object.throwDecodedError (/dev/shm/workspace/parallel/17/kibana/node_modules/selenium-webdriver/lib/error.js:550:15)
[00:02:53]             │       at parseHttpResponse (/dev/shm/workspace/parallel/17/kibana/node_modules/selenium-webdriver/lib/http.js:565:13)
[00:02:53]             │       at Executor.execute (/dev/shm/workspace/parallel/17/kibana/node_modules/selenium-webdriver/lib/http.js:491:26)
[00:02:53]             │       at runMicrotasks (<anonymous>)
[00:02:53]             │       at processTicksAndRejections (internal/process/task_queues.js:95:5)
[00:02:53]             │       at Task.exec (/dev/shm/workspace/parallel/17/kibana/test/functional/services/remote/prevent_parallel_calls.ts:28:20)
[00:02:53]             │ 
[00:02:53]             │

Stack Trace

JavascriptError: javascript error: document unloaded while waiting for result
  (Session info: headless chrome=91.0.4472.114)
    at Object.throwDecodedError (/dev/shm/workspace/parallel/17/kibana/node_modules/selenium-webdriver/lib/error.js:550:15)
    at parseHttpResponse (/dev/shm/workspace/parallel/17/kibana/node_modules/selenium-webdriver/lib/http.js:565:13)
    at Executor.execute (/dev/shm/workspace/parallel/17/kibana/node_modules/selenium-webdriver/lib/http.js:491:26)
    at runMicrotasks (<anonymous>)
    at processTicksAndRejections (internal/process/task_queues.js:95:5)
    at Task.exec (/dev/shm/workspace/parallel/17/kibana/test/functional/services/remote/prevent_parallel_calls.ts:28:20) {
  remoteStacktrace: '#0 0x55b3b862d949 <unknown>\n'
}

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`enterpriseSearch`	2.1MB	2.1MB	-1.3KB

History

💚 Build #133256 succeeded 969daed
💚 Build #132980 succeeded f1502b6
💔 Build #132968 failed ddacc2a94168398cfeae3e70bfdf43bc9aaf0997

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @byronhulcher

…2835) * Update CurationRouter - Remove breadcrumbs set in router (will get set by page template) - Set up a curation breadcrumb helper for DRYness - Remove NotFound route - curation ID 404 handling will be used instead * Convert Curations page to new page template + move Empty State from table to top level * Convert Curation creation page to new page template * Convert single Curation page to new page template + remove breadcrumb prop * Update router * [Polish] Copy changes from Davey - see https://github.com/elastic/kibana/pull/101958/files - Per https://elastic.github.io/eui/#/guidelines/writing we shouldn't be using "new", so I removed that also * [UI polish] Add plus icon to create button - To match other create buttons across app

kibanamachine · 2021-06-23T00:38:03Z

💚 Backport successful

Status	Branch	Result
✅	7.x

This backport PR will be merged automatically after passing CI.

…103031) * Update CurationRouter - Remove breadcrumbs set in router (will get set by page template) - Set up a curation breadcrumb helper for DRYness - Remove NotFound route - curation ID 404 handling will be used instead * Convert Curations page to new page template + move Empty State from table to top level * Convert Curation creation page to new page template * Convert single Curation page to new page template + remove breadcrumb prop * Update router * [Polish] Copy changes from Davey - see https://github.com/elastic/kibana/pull/101958/files - Per https://elastic.github.io/eui/#/guidelines/writing we shouldn't be using "new", so I removed that also * [UI polish] Add plus icon to create button - To match other create buttons across app Co-authored-by: Constance <constancecchen@users.noreply.github.com>

cee-chen added release_note:skip Skip the PR/issue when compiling release notes v7.14.0 auto-backport Deprecated - use backport:version if exact versions are needed labels Jun 21, 2021

cee-chen requested a review from a team June 21, 2021 23:45

cee-chen force-pushed the kibana-page-template-as-8 branch from 780e531 to ddacc2a Compare June 21, 2021 23:50

cee-chen added 6 commits June 21, 2021 18:10

Update CurationRouter

65cf40b

- Remove breadcrumbs set in router (will get set by page template) - Set up a curation breadcrumb helper for DRYness - Remove NotFound route - curation ID 404 handling will be used instead

Convert Curations page to new page template

13c9312

+ move Empty State from table to top level

Convert Curation creation page to new page template

f8d0211

Convert single Curation page to new page template

a7c54c0

+ remove breadcrumb prop

Update router

85b585c

[Polish] Copy changes from Davey

f1502b6

- see https://github.com/elastic/kibana/pull/101958/files - Per https://elastic.github.io/eui/#/guidelines/writing we shouldn't be using "new", so I removed that also

cee-chen force-pushed the kibana-page-template-as-8 branch from ddacc2a to f1502b6 Compare June 22, 2021 01:10

JasonStoltz assigned byronhulcher Jun 22, 2021

byronhulcher approved these changes Jun 22, 2021

View reviewed changes

cee-chen and others added 3 commits June 22, 2021 10:24

Merge branch 'master' into kibana-page-template-as-8

5c79cc3

[UI polish] Add plus icon to create button

969daed

- To match other create buttons across app

Merge branch 'master' into kibana-page-template-as-8

21a3991

cee-chen merged commit e582549 into elastic:master Jun 23, 2021

cee-chen deleted the kibana-page-template-as-8 branch June 23, 2021 00:35

kibanamachine mentioned this pull request Jun 23, 2021

[7.x] [App Search] Convert Curations pages to new page template (#102835) #103031

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[App Search] Convert Curations pages to new page template#102835

[App Search] Convert Curations pages to new page template#102835
cee-chen merged 9 commits intoelastic:masterfrom
cee-chen:kibana-page-template-as-8

cee-chen commented Jun 21, 2021 •

edited

Loading

Uh oh!

kibanamachine commented Jun 23, 2021

Standard Out

Stack Trace

Uh oh!

kibanamachine commented Jun 23, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

cee-chen commented Jun 21, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Screencaps

Checklist

Uh oh!

kibanamachine commented Jun 23, 2021

💛 Build succeeded, but was flaky

Test Failures

Standard Out

Stack Trace

Metrics [docs]

Async chunks

History

Uh oh!

kibanamachine commented Jun 23, 2021

💚 Backport successful

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

cee-chen commented Jun 21, 2021 •

edited

Loading