Skip to content

[7.x] [App Search] Convert Engine subnav and Engine Overview pages to new page template (#102679)#102797

Merged
kibanamachine merged 1 commit intoelastic:7.xfrom
kibanamachine:backport/7.x/pr-102679
Jun 21, 2021
Merged

[7.x] [App Search] Convert Engine subnav and Engine Overview pages to new page template (#102679)#102797
kibanamachine merged 1 commit intoelastic:7.xfrom
kibanamachine:backport/7.x/pr-102679

Conversation

@kibanamachine
Copy link
Contributor

Backports the following commits to 7.x:

…age template (elastic#102679)

* Update routers

- To facilitate this being broken up into multiple PRs, non-migrated views still get a wrapping layout

* Set up Engine subnav in EuiSideNav format

+ tweak CSS for new label - heads up that this will break the old nav, but will disappear as the pages get converted

* Convert Engine Overview pages to new page template

* [PR feedback] Code comment explaining side nav icon reorder

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@kibanamachine
Copy link
Contributor Author

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
enterpriseSearch 2.1MB 2.1MB +18.4KB

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @constancecchen

@kibanamachine kibanamachine merged commit 81dc27d into elastic:7.x Jun 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants