[optimizer] use "unsafe" defaults that have proven to be safe enough#10275
Merged
spalger merged 2 commits intoelastic:masterfrom Feb 15, 2017
Merged
[optimizer] use "unsafe" defaults that have proven to be safe enough#10275spalger merged 2 commits intoelastic:masterfrom
spalger merged 2 commits intoelastic:masterfrom
Conversation
Contributor
|
What do you mean by "while it does sometimes force you to restart the server in order to clear the cache"? Can you add documentation in the CONTRIBUTING guide on when you might need to restart the server? |
spalger
force-pushed
the
update/optimization-defaults
branch
from
aba2391 to
68be975
Compare
jbudz
approved these changes
Feb 14, 2017
tylersmalley
approved these changes
Feb 15, 2017
Member
tylersmalley
left a comment
tylersmalley
left a comment
There was a problem hiding this comment.
LGTM - shaves about half the time off the optimize process.
elastic-jasper
added a commit
that referenced
this pull request
Feb 15, 2017
Backports PR #10275 **Commit 1:** [optimizer] use "unsafe" defaults that have proven to be safe enough * Original sha: 045d624 * Authored by spalger <spalger@users.noreply.github.com> on 2017-02-09T20:52:32Z **Commit 2:** [docs] add a note to the CONTRIBUTING.md regarding potential pitfalls * Original sha: 68be975 * Authored by spalger <spalger@users.noreply.github.com> on 2017-02-14T18:43:39Z
spalger
pushed a commit
that referenced
this pull request
Feb 16, 2017
…10380) Backports PR #10275 **Commit 1:** [optimizer] use "unsafe" defaults that have proven to be safe enough * Original sha: 045d624 * Authored by spalger <spalger@users.noreply.github.com> on 2017-02-09T20:52:32Z **Commit 2:** [docs] add a note to the CONTRIBUTING.md regarding potential pitfalls * Original sha: 68be975 * Authored by spalger <spalger@users.noreply.github.com> on 2017-02-14T18:43:39Z
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we were integrating webpack into 4.2 we were unsure what the
unsafeCachesetting would do, but realized it's performance benefits, so we asked developers to opt-in to using it. Since then it has become apparent that, while it does sometimes force you to restart the server in order to clear the cache webpack is so much faster with it enabled that it is worth it.This change enables it by default in development.