fixes error with saving hidden metrics

[ppisljar]

fixes #9156
when opening a saved visualization with hidden metrics they would show up as if they were not hidden.

[thomasneirynck]

CI is failing. Probably related to dashboard which is failing now on master.

[markharwood]

Residual issue here - when following these steps:

1. Create new pie chart and 2 terms aggs (one for country one for status field)
2. Disable the country agg
3. Run query
4. Save

Pre, the patch, step 4 re-opens the viz with the country agg disabled but country data still showing in the tab:

After applying this patch there is now a different error in step 4 - no data is shown at all in the pie chart after saving :

To reveal data I have to:

1. toggle country agg on
2. run query
3. toggle country agg off
4. run query

[ppisljar]

great catch @markharwood !

[ppisljar]

@markharwood @thomasneirynck i updated this, please take another look.

[markharwood]

Works OK here for me now.

[thomasneirynck]

This works. The hidden metrics are hidden after reopening a visualization with hidden metrics.

There seems to be a small issue, happening right after saving the Viz. The column with the hidden metrics remains visible, but the values are blanked out. This seems particular to Data Table though.

1. Make a Data Table vizualization. Select 3 metrics
2. save this

3. hide a metric

4. save the visualization again. The column with the hidden metric remains visible, but contains no data.