fixing pie chart tooltip custom label bug #10219
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tbragin
added
the
Feature:Visualizations
Contributor
There was a problem hiding this comment.
looks good, IMO, but not sure if failing test is related
WARN: 'Deprecation warning: moment construction falls back to js Date. This is discouraged and will be removed in upcoming major release. Please refer to https://github.com/moment/moment/issues/1407 for more info.
Arguments: [object Object]
Error
at Function.createFromInputFallback (http://localhost:5610/bundles/tests.bundle.js?shards=4&shard_num=1:57429:2711)
at oa (http://localhost:5610/bundles/tests.bundle.js?shards=4&shard_num=1:57429:10866)
at Ia (http://localhost:5610/bundles/tests.bundle.js?shards=4&shard_num=1:57429:14773)
at Ha (http://localhost:5610/bundles/tests.bundle.js?shards=4&shard_num=1:57429:14634)
at Ga (http://localhost:5610/bundles/tests.bundle.js?shards=4&shard_num=1:57429:14354)
at Ja (http://localhost:5610/bundles/tests.bundle.js?shards=4&shard_num=1:57429:15086)
at Ka (http://localhost:5610/bundles/tests.bundle.js?shards=4&shard_num=1:57429:15120)
at a (http://localhost:5610/bundles/tests.bundle.js?shards=4&shard_num=1:57429:203)
at Object.parse (http://localhost:5610/bundles/tests.bundle.js?shards=4&shard_num=1:57482:34)
at Array.validateDateMath (http://localhost:5610/bundles/tests.bundle.js?shards=4&shard_num=1:187704:52)
at Object.ngModelWatch (http://localhost:5610/bundles/tests.bundle.js?shards=4&shard_num=1:47788:37)
at Scope.$digest (http://localhost:5610/bundles/tests.bundle.js?shards=4&shard_num=1:38187:41)
at Context.<anonymous> (http://localhost:5610/bundles/tests.bundle.js?shards=4&shard_num=1:327054:17)
at callFn (http://localhost:9876/base/node_modules/mocha/mocha.js?312499f61e38c4f82b2789b388ced378202a1e75:4471:21)
at Test.Runnable.run (http://localhost:9876/base/node_modules/mocha/mocha.js?312499f61e38c4f82b2789b388ced378202a1e75:4464:7)
at Runner.runTest (http://localhost:9876/base/node_modules/mocha/mocha.js?312499f61e38c4f82b2789b388ced378202a1e75:4934:10)'
Contributor
Author
|
the failing test looks unrelated. |
Contributor
|
Tried it here and it solved the pie chart display issue. |
ppisljar
force-pushed
the
fix/pieTooltipLabels
branch
from
3f36af1 to
573bb16
Compare
ppisljar
force-pushed
the
fix/pieTooltipLabels
branch
from
43bcbb0 to
0ada537
Compare
elastic-jasper
added a commit
that referenced
this pull request
Feb 13, 2017
Backports PR #10219 **Commit 1:** fixing pie chart tooltip custom label bug * Original sha: 573bb16 * Authored by ppisljar <[email protected]> on 2017-02-07T11:40:19Z **Commit 2:** fixing test * Original sha: 0ada537 * Authored by ppisljar <[email protected]> on 2017-02-13T13:18:01Z
ppisljar
pushed a commit
that referenced
this pull request
Feb 13, 2017
Backports PR #10219 **Commit 1:** fixing pie chart tooltip custom label bug * Original sha: 573bb16 * Authored by ppisljar <[email protected]> on 2017-02-07T11:40:19Z **Commit 2:** fixing test * Original sha: 0ada537 * Authored by ppisljar <[email protected]> on 2017-02-13T13:18:01Z
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #6605
pie chart is not taking custom label into account when showing the tooltips