Updating the import saved objects file to include by value saved objects panels and drilldowns#102114
Merged
bhavyarm merged 2 commits intoelastic:masterfrom Jun 15, 2021
Merged
Conversation
ThomThomson
approved these changes
Jun 14, 2021
Contributor
ThomThomson
left a comment
There was a problem hiding this comment.
I didn't look through each new saved object, but I did recreate the error that caused 7.13.2, and found that these tests would have caught it. Thank you again for doing this! Awesome work.
Contributor
|
Pinging @elastic/kibana-qa (Team:QA) |
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: cc @bhavyarm |
LeeDr
approved these changes
Jun 15, 2021
LeeDr
left a comment
There was a problem hiding this comment.
LGTM - code review and Jenkins results only
cuff-links
pushed a commit
to cuff-links/kibana
that referenced
this pull request
Jun 15, 2021
Contributor
Contributor
Author
Contributor
Contributor
Author
|
@ymao1 sweet! Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update from this PR to add saved objects - for by value panels and drilldowns
#100828
These are the saved object types included in the import test:
Missing saved objects: