Skip to content

Updating the import saved objects file to include by value saved objects panels and drilldowns#102114

Merged
bhavyarm merged 2 commits intoelastic:masterfrom
bhavyarm:updateSavedObjectsImportTest
Jun 15, 2021
Merged

Updating the import saved objects file to include by value saved objects panels and drilldowns#102114
bhavyarm merged 2 commits intoelastic:masterfrom
bhavyarm:updateSavedObjectsImportTest

Conversation

@bhavyarm
Copy link
Contributor

@bhavyarm bhavyarm commented Jun 14, 2021

Update from this PR to add saved objects - for by value panels and drilldowns
#100828

These are the saved object types included in the import test:

  • url (2)
  • index-pattern (5)
  • visualization (23)
  • tag (3)
  • map (1)
  • lens (17)
  • search (4)
  • dashboard (9)
  • config (2)
  • graph-workspace (1)
  • timelion-sheet (1)
  • canvas-element (1)
  • query (2)
  • canvas-workpad (1)
  • (Drilldowns - URL, Dashboards) & by Value panels

Missing saved objects:

  • action (0)
  • alert (0)
  • infrastructure-ui-source (0)
  • metrics-explorer-view (0)
  • inventory-view (0)
  • apm-indices (0)

@bhavyarm bhavyarm self-assigned this Jun 14, 2021
@bhavyarm bhavyarm added Feature:Saved Objects Team:QA Platform QA t// release_note:skip Skip the PR/issue when compiling release notes test_xpack_functional backport:skip This PR does not require backporting v8.0.0 labels Jun 14, 2021
@bhavyarm bhavyarm requested review from LeeDr and ThomThomson June 14, 2021 18:49
Copy link
Contributor

@ThomThomson ThomThomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't look through each new saved object, but I did recreate the error that caused 7.13.2, and found that these tests would have caught it. Thank you again for doing this! Awesome work.

@bhavyarm bhavyarm marked this pull request as ready for review June 14, 2021 21:50
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-qa (Team:QA)

@bhavyarm
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @bhavyarm

Copy link

@LeeDr LeeDr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - code review and Jenkins results only

@bhavyarm bhavyarm merged commit 3decc35 into elastic:master Jun 15, 2021
cuff-links pushed a commit to cuff-links/kibana that referenced this pull request Jun 15, 2021
@arisonl
Copy link
Contributor

arisonl commented Jun 28, 2021

@LeeDr @ymao1 as we are merging import/export of alerts and actions, can we add them to the test automation?

@bhavyarm
Copy link
Contributor Author

@arisonl I chatted with @ymao1 about this and the plan is to add them once they are not hidden behind a config flag anymore. As I understand - in 7.14 - we need to turn on the flag. Thanks!

@ymao1
Copy link
Contributor

ymao1 commented Jun 28, 2021

@bhavyarm I am about to merge this PR #102999 for 7.14 that removes the feature flag, so let's coordinate about what is needed to add them to the tests.

@bhavyarm
Copy link
Contributor Author

@ymao1 sweet! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting Feature:Saved Objects release_note:skip Skip the PR/issue when compiling release notes Team:QA Platform QA t// test_xpack_functional v8.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants