Skip to content

[Enterprise Search] Add owner and description properties to kibana.json#101957

Merged
scottybollinger merged 3 commits intoelastic:masterfrom
scottybollinger:scottybollinger/owners-kibanajson
Jun 11, 2021
Merged

[Enterprise Search] Add owner and description properties to kibana.json#101957
scottybollinger merged 3 commits intoelastic:masterfrom
scottybollinger:scottybollinger/owners-kibanajson

Conversation

@scottybollinger
Copy link
Copy Markdown
Contributor

Summary

Adds owner and description properties to kibana.json. Original request

Adds owner and description properties to kibana.json
@scottybollinger scottybollinger requested a review from a team June 10, 2021 19:57
@scottybollinger scottybollinger added auto-backport Deprecated - use backport:version if exact versions are needed Feature:Plugins release_note:skip Skip the PR/issue when compiling release notes v7.14.0 labels Jun 10, 2021
Both others have the props at the end of the file:

https://github.com/elastic/kibana/blob/master/src/plugins/bfetch/kibana.json

Also removes redundant prefix from description
Copy link
Copy Markdown
Contributor

@cee-chen cee-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for grabbing this so quickly Scotty! I only just saw the email announcement lol. Minor optional copy suggestion, feel free to tweak it further or ignore, up to you. We could also rope in @chriscressman when he gets back next week if we really wanted to 🤔

Co-authored-by: Constance <constancecchen@users.noreply.github.com>
@scottybollinger scottybollinger enabled auto-merge (squash) June 10, 2021 22:00
@kibanamachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@scottybollinger scottybollinger merged commit f28777f into elastic:master Jun 11, 2021
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jun 11, 2021
…on (elastic#101957)

* [Enterprise Search] Add owner and description properties to kibana.json

Adds owner and description properties to kibana.json

* Reorder to match other plugins

Both others have the props at the end of the file:

https://github.com/elastic/kibana/blob/master/src/plugins/bfetch/kibana.json

Also removes redundant prefix from description

* Copy change

Co-authored-by: Constance <constancecchen@users.noreply.github.com>

Co-authored-by: Constance <constancecchen@users.noreply.github.com>
@kibanamachine
Copy link
Copy Markdown
Contributor

💚 Backport successful

Status Branch Result
7.x

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Jun 11, 2021
…on (#101957) (#101978)

* [Enterprise Search] Add owner and description properties to kibana.json

Adds owner and description properties to kibana.json

* Reorder to match other plugins

Both others have the props at the end of the file:

https://github.com/elastic/kibana/blob/master/src/plugins/bfetch/kibana.json

Also removes redundant prefix from description

* Copy change

Co-authored-by: Constance <constancecchen@users.noreply.github.com>

Co-authored-by: Constance <constancecchen@users.noreply.github.com>

Co-authored-by: Scotty Bollinger <scotty.bollinger@elastic.co>
Co-authored-by: Constance <constancecchen@users.noreply.github.com>
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jun 14, 2021
* master: (68 commits)
  skip flaky suite (elastic#94043)
  skip flaky suite (elastic#102012)
  [esArchive] Persists updates for management/saved_objects/* (elastic#101992)
  skip flaky suite (elastic#101449)
  remove unnecessary hack (elastic#101909)
  [Exploratory View] Use human readable formats (elastic#101520)
  [Expressions] Refactor expression functions to use observables underneath (elastic#100409)
  [esArchives] Persist migrated Kibana archives (elastic#101950)
  [kbnArchiver] fix save to non-existent file (elastic#101974)
  [Enterprise Search] Add owner and description properties to kibana.json (elastic#101957)
  [DOCS] Fixes terminology in Stack Monitoring:Kibana alerts (elastic#101696)
  [Observability] [Cases] Cases in the observability app (elastic#101487)
  [Alerting][Docs] Combine rule creation and management pages (elastic#101498)
  temporarily disable build-buddy
  [Fleet] Fix fleet server collector in case settings are not set (elastic#101752)
  [Event Log] Populated rule.* ECS fields for alert events. (elastic#101132)
  [APM] Fleet support for merging input.config values with other nested properties in the policy input (elastic#101690)
  Add comments to some alerting plugin public API items (elastic#101551)
  [Alerting][Docs] Moving alerting setup to its own page (elastic#101323)
  remove uptime public API, it's not used. (elastic#101799)
  ...
@scottybollinger scottybollinger deleted the scottybollinger/owners-kibanajson branch June 24, 2021 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-backport Deprecated - use backport:version if exact versions are needed Feature:Plugins release_note:skip Skip the PR/issue when compiling release notes v7.14.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants