Skip to content

[APM] Remove omitEsFieldValue and update parseEnvironmentUrlParam#101876

Merged
sorenlouv merged 8 commits intoelastic:masterfrom
sorenlouv:minor-refactor-esFieldValue-helper
Jun 17, 2021
Merged

[APM] Remove omitEsFieldValue and update parseEnvironmentUrlParam#101876
sorenlouv merged 8 commits intoelastic:masterfrom
sorenlouv:minor-refactor-esFieldValue-helper

Conversation

@sorenlouv
Copy link
Member

Related to: #95903 (comment)

@sorenlouv sorenlouv requested a review from a team June 10, 2021 11:07
@botelastic botelastic bot added the Team:APM - DEPRECATED Use Team:obs-ux-infra_services. label Jun 10, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@sorenlouv sorenlouv added release_note:skip Skip the PR/issue when compiling release notes v7.14.0 labels Jun 10, 2021
@sorenlouv
Copy link
Member Author

jenkins run the e2e

@sorenlouv sorenlouv force-pushed the minor-refactor-esFieldValue-helper branch from 9fc8364 to 722558d Compare June 14, 2021 13:35
@sorenlouv sorenlouv requested a review from dgieselaar June 14, 2021 13:37
@sorenlouv sorenlouv added the auto-backport Deprecated - use backport:version if exact versions are needed label Jun 15, 2021
@sorenlouv sorenlouv force-pushed the minor-refactor-esFieldValue-helper branch from 27f7e4a to 36a758b Compare June 16, 2021 07:00
@kibanamachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 4.2MB 4.2MB -4.9KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
apm 33.0KB 37.6KB +4.5KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@sorenlouv sorenlouv merged commit ca52347 into elastic:master Jun 17, 2021
@sorenlouv sorenlouv deleted the minor-refactor-esFieldValue-helper branch June 17, 2021 13:54
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jun 17, 2021
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
7.x

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Jun 17, 2021
…#101876) (#102508)

Co-authored-by: Søren Louv-Jansen <sorenlouv@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:APM - DEPRECATED Use Team:obs-ux-infra_services. v7.14.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants