Allow navigating discover flyout via arrow keys#101772
Merged
timroes merged 1 commit intoelastic:masterfrom Jun 10, 2021
Merged
Allow navigating discover flyout via arrow keys#101772timroes merged 1 commit intoelastic:masterfrom
timroes merged 1 commit intoelastic:masterfrom
Conversation
timroes
added
auto-backport
Contributor
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
majagrubic
approved these changes
Jun 10, 2021
Contributor
majagrubic
left a comment
majagrubic
left a comment
There was a problem hiding this comment.
Looks great! Would be nice to test it in different browsers if you haven't already.
Contributor
Author
|
Tested it on Firefox and Chrome. Maybe someone with a Mac could still test this on Safari?q |
dimaanj
approved these changes
Jun 10, 2021
Contributor
dimaanj
left a comment
dimaanj
left a comment
There was a problem hiding this comment.
LGTM, tested in Safari, Chrome, Firefox, and works for both pages discover and context
kertal
approved these changes
Jun 10, 2021
Member
kertal
left a comment
kertal
left a comment
There was a problem hiding this comment.
Didn't test as I currently working on reviewing Dimas work, but since everybody is approving it, I also wanna be part of this party (And I wanna express happiness for such a little nice UX improvment )
Contributor
💚 Build SucceededMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jun 10, 2021
Contributor
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Jun 10, 2021
…add-integrations-redirect * 'master' of github.com:elastic/kibana: (44 commits) Allow navigating discover flyout via arrow keys (elastic#101772) [Cases] Improve connectors mapping (elastic#101145) [ML] Fixes display of job group badges in recognizer wizard (elastic#101775) Fix es_archives path (elastic#101737) [kbnArchiver] convert archive names to root-relative paths (elastic#101839) [Reporting] Make "ScreenCapturePanel" shareable for Canvas (elastic#100623) [Alerting UI] Converted Rules and Connectors management pages to new layout. (elastic#101697) [Fleet] Support granular integrations in policy editor (elastic#101531) [Security Solution][Detections] Update detection alert mappings to ECS v1.10.0 (elastic#101680) [Fleet] Integrations UI: Adjust policies list UI (elastic#101600) chore(NA): moving @kbn/server-route-repository into bazel (elastic#101484) Support owner and description attributes inside the Manifest file, use in API docs (elastic#101786) [Security Solution] fix security empty overview links (elastic#101536) Unskips migration tests now that elastic search is fixed (elastic#101682) Fix endpoint -> integrations onboarding link (elastic#101804) [Alerting] Log warning when rules are not rescheduled due to Saved Object not found error (elastic#101591) Update datafeed_high_count_network_denies.json (elastic#101681) [Index patterns] Field editor example app (elastic#100524) [DOCS] Adding file upload to add data page (elastic#101674) [Security Solution][Endpoint] Adds Endpoint Host Isolation Status common component (elastic#101782) ... # Conflicts: # x-pack/plugins/fleet/public/applications/fleet/sections/agent_policy/create_package_policy_page/index.tsx # x-pack/plugins/fleet/public/applications/fleet/sections/agent_policy/details_page/components/package_policies/package_policies_table.tsx
kibanamachine
added a commit
that referenced
this pull request
Jun 10, 2021
semd
pushed a commit
that referenced
this pull request
Jun 10, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Small change that will allow navigating the document flyout via the → and ← keys.
Checklist
Delete any items that are not applicable to this PR.