allow visualizations to have full width editor#10175
Merged
ppisljar merged 3 commits intoelastic:masterfrom Feb 6, 2017
Merged
allow visualizations to have full width editor#10175ppisljar merged 3 commits intoelastic:masterfrom
ppisljar merged 3 commits intoelastic:masterfrom
Conversation
ppisljar
changed the title
ppisljar
force-pushed
the
visualize/showSidebar
branch
from
3e7b2d7 to
ebd3926
Compare
ppisljar
changed the title
simianhacker
requested changes
Feb 3, 2017
Member
simianhacker
left a comment
simianhacker
left a comment
There was a problem hiding this comment.
Everything works perfectly with the exception of those changes.
| flex: 1 0 auto; | ||
| padding: 0px; | ||
| } | ||
|
|
Member
There was a problem hiding this comment.
This needs to be added to .visualization-options:
or override .visualization-options inside .vis-editor-full-options with those settings.
simianhacker
approved these changes
Feb 3, 2017
Member
|
LGTM |
thomasneirynck
approved these changes
Feb 6, 2017
elastic-jasper
added a commit
that referenced
this pull request
Feb 6, 2017
Backports PR #10175 **Commit 1:** allow visualizations to hide sidebar editor * Original sha: ebd3926 * Authored by ppisljar <peter.pisljar@gmail.com> on 2017-02-03T09:51:12Z **Commit 2:** fixing styles * Original sha: 10d6cff * Authored by ppisljar <peter.pisljar@gmail.com> on 2017-02-03T14:37:54Z **Commit 3:** fixing broken html * Original sha: 7a6aa89 * Authored by ppisljar <peter.pisljar@gmail.com> on 2017-02-03T15:00:45Z
ppisljar
pushed a commit
that referenced
this pull request
Feb 6, 2017
Backports PR #10175 **Commit 1:** allow visualizations to hide sidebar editor * Original sha: ebd3926 * Authored by ppisljar <peter.pisljar@gmail.com> on 2017-02-03T09:51:12Z **Commit 2:** fixing styles * Original sha: 10d6cff * Authored by ppisljar <peter.pisljar@gmail.com> on 2017-02-03T14:37:54Z **Commit 3:** fixing broken html * Original sha: 7a6aa89 * Authored by ppisljar <peter.pisljar@gmail.com> on 2017-02-03T15:00:45Z
simianhacker
added a commit
to simianhacker/kibana
that referenced
this pull request
Feb 6, 2017
tbragin
added
the
Feature:Visualizations
ppisljar
pushed a commit
to ppisljar/kibana
that referenced
this pull request
Feb 28, 2017
simianhacker
added a commit
that referenced
this pull request
Mar 2, 2017
* Initial import * updating the editor width to match the new specs * Adding tribe node support * Adding tests for server libs * removing bluebird * removing extra cruft * Fixing the font sizes * Fixed the updating code * Adding brushing * Fixing linting issues * Adding global filters * Adding missing packages * Default gauge style to half circle * Fixing the markdown css bug * Adding tests for the get_vis_data api * Adding time offset * Adding time offset to each type * fixing bugs from time offset * adding index pattern option to series * Adding index pattern overrides * Adding index pattern overrides * Fixing tests * Fixing brushing in the vis editor * Changing the label * Change the behavior of selecting a pipeline agg when only one exists. * Refactoring series a bit * Changing series options to just options * Making sure we honor the toaster container height * Adding first tests * renaming vis_config to panel_config * renaming vis_config to panel_config * Adding more tests * adding more tests * removing api subdirectory * refactoring get_vis_data (breaking it up and removing unused imports) * reorganizing the visualization directory * Re-organizing directory layouts and moving things to more logical places * Refactoring React compontents to use ES6 syntax and adding propTypes for each. Also refactored out splats as much as possible. * Adding serial differencing * Refactored gauge to use 2 components instead of 4 * Finishing react refactor on visualizations. Consolidated legned funtionality * Refactoring series config and removing a bunch of duplicate code * fixing series config name * Fixing numbers and strings (doesnt matter which it is); Fixing classname * Changing the way the dark theme works * Adding new vis into list for test * Adding empty bucket check * Fixing the index patterns in the aggs * Fixing typo * Refactoring vis_data * Fixing std_metric * Fixing refresh-hack * Adding tests for get_splits, get_last_metric, map_bucket * Fixing the error handing * removing restrictions * Sometimes values are strings or numbers... it doesn't matter * Adding new color options for splits * Fixing colors * fixing size * Adding support for fitlers agg * Fixing tests * Fixing splits for filters * Fixing Top N to work better with fitlers * Adding annotation editor * initial work for annotations * Finalizing annotations * Fixing label * making it expandable * Fixing hacks fixed by #10175 * Fixing bars to use the same stacking options as lines * Getting rid of align by colons * removing unused depends * removing unused depends * Changing to readable lodash function * Adding missing parens * refactoring custom color picker * Removing string refs and converting uncontrolled components * Fixing the controlled components where value maybe null; converting error to css * refactoring styles from components * fixing the refresh behavoir borked by fullEditor * Adding the executor service * Fixing the test directories * fixing save * Adding filter ratios * Fixing controlled components * Trying to fix the weird typing * Fixing offset bug with days * Adding percentile rank * Fixing yaxis updates; fixing percentile rank layout; adding steps to line chart * removing unused depends * Fixed a bug with the index patterns updating; fixed bug with charts rendering too much * Fixing tests * Commenting out React tests because the ENV must have change and they are no longer working * Moving bucket transform * moving calculate auto * Moving calculate_indices * moving extended_stats_types && get_agg_value * moving get_buckets_path * moving get_sibling_agg_value * moving parse_settings * moving series_agg * Moving unit_to_seconds * Fixing tests * Fixing per PR * Renaming vars to make it more clear what's happening * Changing the way testible functions are exported * fixing tests * removing unused imports; fixing typos; fixing package name * Name has to match the plugin path * Fixing typos; removing unused imports * fixing tests * rearanging and removing unused imports * Fixing a bug with unque names for radio buttons on the same form * Fixing filter ratio to use a metric instead of just count * fixing a bug with the new filter ratios * Fixing the file path from the #8 * Fixing renderComplete trigger; Fixing embedded mode; Changing names for Timelion and Time Series Visual Builder * Fixing name * Fixing docs * Fixing a typo for the field select for terms splits * Fixing tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
allows visualization type to specify
fullEditor: trueto not show the visualization when in edit mode but rather expand editor to the full width.