Skip to content

[Fleet] Display NOTICE.txt from package if it exists#101663

Merged
nchaulet merged 3 commits intoelastic:masterfrom
nchaulet:feature-display-package-notice
Jun 14, 2021
Merged

[Fleet] Display NOTICE.txt from package if it exists#101663
nchaulet merged 3 commits intoelastic:masterfrom
nchaulet:feature-display-package-notice

Conversation

@nchaulet
Copy link
Copy Markdown
Member

@nchaulet nchaulet commented Jun 8, 2021

Summary

Resolve #100351
The package registry recently introduced NOTICE.txt file (elastic/package-spec#151)

That PR display a link to the NOTICE.txt and show the content of the file inside a modal in the package details view

Currently only the security detection rule package use that file

UI Changes

Screen Shot 2021-06-08 at 3 14 45 PM

Screen Shot 2021-06-08 at 3 19 27 PM

@nchaulet nchaulet added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v7.14.0 auto-backport Deprecated - use backport:version if exact versions are needed labels Jun 8, 2021
@nchaulet nchaulet self-assigned this Jun 8, 2021
@nchaulet nchaulet requested a review from a team as a code owner June 8, 2021 19:31
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/fleet (Team:Fleet)

@nchaulet nchaulet force-pushed the feature-display-package-notice branch from 0a3f0ed to 2a43396 Compare June 8, 2021 19:36
@nchaulet nchaulet requested a review from jfsiii June 8, 2021 19:52
@nchaulet
Copy link
Copy Markdown
Member Author

@elasticmachine merge upstream

@nchaulet
Copy link
Copy Markdown
Member Author

@elasticmachine merge upstream

@nchaulet nchaulet enabled auto-merge (squash) June 14, 2021 14:29
@kibanamachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
fleet 475 476 +1

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
fleet 1007 1009 +2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
fleet 710.7KB 713.8KB +3.1KB
Unknown metric groups

API count

id before after diff
fleet 1097 1099 +2

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @nchaulet

@kibanamachine
Copy link
Copy Markdown
Contributor

💚 Backport successful

Status Branch Result
7.x

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Jun 14, 2021
Co-authored-by: Nicolas Chaulet <nicolas.chaulet@elastic.co>
cuff-links pushed a commit to cuff-links/kibana that referenced this pull request Jun 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v7.14.0 v8.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Fleet] Add NOTICE.txt modal for integrations that contain one

5 participants