Skip to content

Use fake timers to avoid test flakiness#101254

Merged
lizozom merged 1 commit intoelastic:masterfrom
lizozom:flaky/101126
Jun 3, 2021
Merged

Use fake timers to avoid test flakiness#101254
lizozom merged 1 commit intoelastic:masterfrom
lizozom:flaky/101126

Conversation

@lizozom
Copy link
Copy Markdown
Contributor

@lizozom lizozom commented Jun 3, 2021

Summary

Caused by #97994
Resolves #101126

Checklist

Delete any items that are not applicable to this PR.

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

Risk Probability Severity Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space. Low High Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. High Low Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled. Medium High Unit tests will verify that any feature flag or plugin combination still results in our service operational.
See more potential risk examples

For maintainers

@lizozom lizozom self-assigned this Jun 3, 2021
@lizozom lizozom requested a review from a team as a code owner June 3, 2021 10:26
@botelastic botelastic bot added the Feature:ExpressionLanguage Interpreter expression language (aka canvas pipeline) label Jun 3, 2021
@lizozom lizozom added auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes v7.14.0 v8.0.0 Team:AppServices labels Jun 3, 2021
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/kibana-app-services (Team:AppServices)

Copy link
Copy Markdown
Contributor

@streamich streamich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kibanamachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @lizozom

@lizozom lizozom merged commit c30dc1e into elastic:master Jun 3, 2021
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jun 3, 2021
@kibanamachine
Copy link
Copy Markdown
Contributor

💚 Backport successful

Status Branch Result
7.x

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Jun 3, 2021
Co-authored-by: Liza Katz <lizka.k@gmail.com>
spalger pushed a commit to spalger/kibana that referenced this pull request Jul 8, 2021
# Conflicts:
#	src/plugins/bfetch/public/batching/create_streaming_batched_function.test.ts
spalger pushed a commit that referenced this pull request Jul 8, 2021
# Conflicts:
#	src/plugins/bfetch/public/batching/create_streaming_batched_function.test.ts

Co-authored-by: Liza Katz <lizka.k@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-backport Deprecated - use backport:version if exact versions are needed Feature:ExpressionLanguage Interpreter expression language (aka canvas pipeline) release_note:skip Skip the PR/issue when compiling release notes v7.14.0 v8.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Failing test: Jest Tests.src/plugins/bfetch/public/batching - createStreamingBatchedFunction() when buffer becomes full dispatches batch request

4 participants