Skip to content

[bfetch] fflate tree shaking#101147

Merged
lizozom merged 2 commits intoelastic:masterfrom
lizozom:bfetch/fflate-import
Jun 3, 2021
Merged

[bfetch] fflate tree shaking#101147
lizozom merged 2 commits intoelastic:masterfrom
lizozom:bfetch/fflate-import

Conversation

@lizozom
Copy link
Copy Markdown
Contributor

@lizozom lizozom commented Jun 2, 2021 •
edited
Loading

Summary

Applied changes as suggested by @101arrowz in #97994 (comment) to reduce shared-deps bundle size

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@lizozom lizozom self-assigned this Jun 2, 2021
@lizozom
Copy link
Copy Markdown
Contributor Author

lizozom commented Jun 2, 2021

@elasticmachine merge upstream

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Jun 2, 2021

💚 Build Succeeded

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
kbnUiSharedDeps-elastic 2.6MB 2.6MB -1.0B
kbnUiSharedDeps-js 6.5MB 6.4MB -25.1KB
total -25.1KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @lizozom

@lizozom lizozom marked this pull request as ready for review June 2, 2021 22:37
@lizozom lizozom requested a review from a team as a code owner June 2, 2021 22:37
@spalger spalger added v7.14.0 release_note:skip Skip the PR/issue when compiling release notes Team:Operations Kibana-Operations Team v8.0.0 labels Jun 2, 2021
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Jun 2, 2021

Pinging @elastic/kibana-operations (Team:Operations)

@lizozom lizozom changed the title [bfetch] Attempt at tree shaking [bfetch] fflate tree shaking Jun 2, 2021
spalger
spalger approved these changes Jun 2, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@spalger spalger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, LGTM

@lizozom lizozom added the auto-backport Deprecated - use backport:version if exact versions are needed label Jun 3, 2021
@lizozom lizozom merged commit 8097f36 into elastic:master Jun 3, 2021
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Jun 3, 2021
@lizozom @kibanamachine
attempt at tree shaking (elastic#101147)
040dcfd 
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@kibanamachine kibanamachine mentioned this pull request Jun 3, 2021
Merged
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Jun 3, 2021

💚 Backport successful

Status Branch Result
✅ 7.x

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Jun 3, 2021
@kibanamachine @lizozom
attempt at tree shaking (#101147) (#101251)
d23ef96 
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Liza Katz <lizka.k@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jbudz jbudz jbudz approved these changes

+1 more reviewer

@spalger spalger spalger approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@lizozom lizozom

Labels

auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:Operations Kibana-Operations Team v7.14.0 v8.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@lizozom @kibanamachine @elasticmachine @spalger @jbudz