Skip to content

[7.x] [Expressions] Use table column ID instead of name when set (#99724)#101110

Merged
wylieconlon merged 1 commit intoelastic:7.xfrom
wylieconlon:backport/7.x/pr-99724
Jun 1, 2021
Merged

[7.x] [Expressions] Use table column ID instead of name when set (#99724)#101110
wylieconlon merged 1 commit intoelastic:7.xfrom
wylieconlon:backport/7.x/pr-99724

Conversation

@wylieconlon
Copy link
Contributor

Backports the following commits to 7.x:

…9724)

* [Expressions] Use table column ID instead of name when set

* Update ID matching to match by name sometimes

* Add an extra case to prevent insertion of duplicate column

* Simplify logic and add test for output ID

* Respond to review comments

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@wylieconlon wylieconlon added the backport This PR is a backport of another PR label Jun 1, 2021
@wylieconlon wylieconlon enabled auto-merge (squash) June 1, 2021 21:09
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
expressions 198.8KB 199.2KB +333.0B
Unknown metric groups

References to deprecated APIs

id before after diff
canvas 29 25 -4
crossClusterReplication 8 6 -2
fleet 22 20 -2
globalSearch 4 2 -2
indexManagement 12 7 -5
infra 256 146 -110
lens 67 45 -22
licensing 18 15 -3
lists 239 236 -3
maps 286 208 -78
ml 121 115 -6
monitoring 109 56 -53
securitySolution 390 346 -44
stackAlerts 101 95 -6
total -340

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@wylieconlon wylieconlon merged commit 1a2e46b into elastic:7.x Jun 1, 2021
@wylieconlon wylieconlon deleted the backport/7.x/pr-99724 branch June 2, 2021 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants