[APM] Add Obs side nav and refactor APM templates#101044
[APM] Add Obs side nav and refactor APM templates#101044sorenlouv merged 12 commits intoelastic:masterfrom
Conversation
| text: string; | ||
| }) { | ||
| return { value, text }; | ||
| } |
There was a problem hiding this comment.
This is needed due to a console error introduced in #95903 (comment)
I don't think the console error in itself is an issue but it made it a bit harder to make the changes needed for this PR when the console contained unrelated errors.
| </RedirectAppLinks> | ||
| ); | ||
| } | ||
| import { ApmAppRoot } from '../components/routing/app_root'; |
There was a problem hiding this comment.
Moved all of this to the routing section (which contains routing and templating)
| </MetadataFlexGroup> | ||
| )} | ||
| <SearchBar /> | ||
| <EuiPage> |
There was a problem hiding this comment.
I've removed EuiPage everywhere. Everything is now wrapped in EuiPage automatically when using ApmMainTemplate
| <> | ||
| <SearchBar /> | ||
| <EuiPage> | ||
| <EuiFlexGroup direction="column" gutterSize="s"> |
There was a problem hiding this comment.
We had a lot of unnecessary EuiFlexGroup wrappers. Removed them
| </EuiFlexGroup> | ||
| </EuiPage> | ||
|
|
||
| <EuiPanel hasShadow={false}> |
There was a problem hiding this comment.
If there's only a single EuiPanel in a view we use hasShadow={false}. When there are multiple panels we still want the drop shadow.
| @@ -0,0 +1,38 @@ | |||
| /* | |||
There was a problem hiding this comment.
renderAsRedirectTo is not new. It was just extracted from another file
| * Optionally: | ||
| * - EnvironmentFilter | ||
| */ | ||
| export function ApmMainTemplate({ |
There was a problem hiding this comment.
This is the core of this PR: an apm-wide template that should contain all elements that most views need (left-side nav, top-bar action menu, page title, environment filter)
sorenlouv
force-pushed
the
add-shared-obs-nav
branch
from
72d877d to
9d96d30
Compare
botelastic
bot
added
Team:APM - DEPRECATED
|
Pinging @elastic/uptime (Team:uptime) |
|
Pinging @elastic/apm-ui (Team:apm) |
x-pack/plugins/apm/public/components/app/ErrorGroupDetails/index.tsx
Outdated
Show resolved
Hide resolved
x-pack/plugins/apm/public/components/app/error_group_overview/index.tsx
Outdated
Show resolved
Hide resolved
x-pack/plugins/apm/public/components/app/service_inventory/index.tsx
Outdated
Show resolved
Hide resolved
|
@sqren do you mind running the e2e test, I think it might break. (It's not running on CI yet, I still need to make a few improvements.) |
|
retest |
1 similar comment
|
retest |
cauemarcondes
left a comment
cauemarcondes
left a comment
There was a problem hiding this comment.
LGTM, thanks for the clean up 👍🏻.
|
@elasticmachine merge upstream |
|
jenkins run the e2e |
smith
left a comment
smith
left a comment
There was a problem hiding this comment.
Thank you! This looks great and tons of good cleanup.
| children, | ||
| }: { | ||
| pageTitle: React.ReactNode; | ||
| environmentSelector?: boolean; |
There was a problem hiding this comment.
nit: Should this be hasEnvironmentSelector or showEnvironmentSelector to indicate it's a boolean. As it's named it makes it look like I'm supposed to supply some sort of environmentSelector here.
💚 Build SucceededMetrics [docs]Module Count
Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
kibanamachine
added
the
backport missing
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
sorenlouv
added
the
auto-backport
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
kibanamachine
removed
the
backport missing
6 participants
Closes #99883
This PR adds the new Observability Page Template including left side nav
I had to refactor quite a few of the existing components, and started templatizing views. This is still WIP and I want to get people's take on the current direction of this PR.