Migrate kibana.autocomplete config to data plugin#100586
Merged
lukasolson merged 7 commits intoelastic:masterfrom Jun 1, 2021
Merged
Migrate kibana.autocomplete config to data plugin#100586lukasolson merged 7 commits intoelastic:masterfrom
lukasolson merged 7 commits intoelastic:masterfrom
Conversation
lukasolson
added
review
release_note:deprecation
v8.0.0
Team:AppServices
v7.14.0
auto-backport
Contributor
|
Pinging @elastic/kibana-app-services (Team:AppServices) |
pgayvallet
approved these changes
May 25, 2021
Contributor
pgayvallet
left a comment
pgayvallet
left a comment
There was a problem hiding this comment.
LGTM once core docs are updated.
5 tasks
crob611
approved these changes
May 26, 2021
Contributor
crob611
left a comment
crob611
left a comment
There was a problem hiding this comment.
Presentation changes look good to me.
Contributor
Author
|
@elasticmachine merge upstream |
lukasolson
force-pushed
the
migrate-autocomplete-config
branch
from
e924959 to
e218549
Compare
Contributor
Author
|
@elasticmachine merge upstream |
tsullivan
approved these changes
Jun 1, 2021
Member
tsullivan
left a comment
tsullivan
left a comment
There was a problem hiding this comment.
LGTM
Reviewed the code and ran tests on the changes locally
Contributor
💚 Build Succeeded
Metrics [docs]Page load bundle
Unknown metric groupsReferences to deprecated APIs
History
To update your PR or re-run it, just comment with: cc @lukasolson |
kibanamachine
added a commit
to kibanamachine/kibana
that referenced
this pull request
Jun 1, 2021
* Migrate kibana.autocomplete config to data plugin * Fix CI * Fix tests Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Contributor
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
kibanamachine
added a commit
that referenced
this pull request
Jun 1, 2021
* Migrate kibana.autocomplete config to data plugin * Fix CI * Fix tests Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Lukas Olson <olson.lukas@gmail.com>
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Jun 2, 2021
…sens/kibana into reporting/new-png-pdf-report-type * 'reporting/new-png-pdf-report-type' of github.com:jloleysens/kibana: (46 commits) [Security Solution] Add Ransomware canary advanced policy option (elastic#101068) [Exploratory view] Core web vitals (elastic#100320) [Security solution][Endpoint] Add unit tests for fleet event filters/trusted apps cards (elastic#101034) [Lens] Use a setter function for the dimension panel (elastic#101123) [Index Patterns] Fix return saved index pattern object (elastic#101051) [CI] For PRs, build TS refs before public api docs check (elastic#100791) [Maps] fix line and polygon label regression (elastic#101085) Migrate CCR to new ES JS client. (elastic#100131) [Canvas] Switch Canvas to use React Router (elastic#100579) [Expressions] Use table column ID instead of name when set (elastic#99724) [DOCS] Updates docs landing page (elastic#100749) [DOCS] Corrects typo in step 3 (elastic#101079) [DOCS] Updates runtime example in Discover (elastic#100926) Migrate kibana.autocomplete config to data plugin (elastic#100586) [Uptime] New width/delay definition for waterfall sidebar item tooltip (elastic#100147) [FTR] Use importExport for saved_object/basic archive (elastic#100244) [Fleet] Better input for multi text input in agent policy builder (elastic#101020) [CI] Buildkite support with Baseline pipeline (elastic#100492) [Reporting/Telemetry] Do not send telemetry if we are in screenshot mode (elastic#100388) Create API keys with metadata (elastic#100682) ...
KOTungseth
added a commit
that referenced
this pull request
Nov 17, 2021
KOTungseth
added a commit
that referenced
this pull request
Nov 17, 2021
KOTungseth
added a commit
to KOTungseth/kibana
that referenced
this pull request
Nov 17, 2021
KOTungseth
added a commit
to KOTungseth/kibana
that referenced
this pull request
Nov 17, 2021
KOTungseth
added a commit
that referenced
this pull request
Nov 19, 2021
KOTungseth
added a commit
that referenced
this pull request
Nov 19, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #66085.
Migrates the
kibana.autocompleteTerminateAfterandkibana.autocompleteTimeoutconfig to the data plugin asdata.autocomplete.terminateAfteranddata.autocomplete.timeout.Checklist
Release note
The
kibana.autocompleteTerminateAfterandkibana.autocompleteTimeoutconfig settings have been renamed asdata.autocomplete.valueSuggestions.terminateAfteranddata.autocomplete.valueSuggestions.timeoutrespectively.