Skip to content

Space management page UX improvements #100448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 25 commits into from
Jul 20, 2021
Merged

Space management page UX improvements #100448

Show file tree
Hide file tree
Changes from 8 commits
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
0a29cd0
Updated spaces management page
thomheymann May 20, 2021
8a2e9d6
Fixed test failures
thomheymann May 25, 2021
5ff57d5
updated snapshot
thomheymann May 25, 2021
cc85b6e
Added suggestions form code review
thomheymann May 26, 2021
f51b442
Fixed unit test
thomheymann May 26, 2021
7ef225d
Review suggestion #2
thomheymann May 27, 2021
e27789a
Merge branch 'master' into manage-spaces
kibanamachine May 27, 2021
8024e7a
Merge branch 'master' into manage-spaces
kibanamachine Jun 1, 2021
65d17c2
Merge branch 'master' of github.com:elastic/kibana into manage-spaces
thomheymann Jun 28, 2021
208e4e9
WIP
thomheymann Jun 28, 2021
62ace6c
Merge branch 'master' of github.com:elastic/kibana into manage-spaces
thomheymann Jul 5, 2021
ec926a7
Fix build errors
thomheymann Jul 5, 2021
9b2d4c8
fix type
thomheymann Jul 5, 2021
9cf8361
remove test for popup that doesnt exist anymore
thomheymann Jul 5, 2021
b63994f
fix test
thomheymann Jul 5, 2021
681d9c1
fix a11y issues
thomheymann Jul 6, 2021
95bd4d5
fix a11y issue
thomheymann Jul 6, 2021
5c3f3de
Removed unused css
thomheymann Jul 6, 2021
53ed64a
Merge branch 'master' of github.com:elastic/kibana into manage-spaces
thomheymann Jul 6, 2021
8ef4b24
Fix functional test
thomheymann Jul 6, 2021
7668cdb
Merge branch 'master' of github.com:elastic/kibana into manage-spaces
thomheymann Jul 12, 2021
bc3df22
Added suggestions from code review
thomheymann Jul 12, 2021
eb998e1
Fix typescript errors
thomheymann Jul 12, 2021
21168e7
Merge branch 'master' of github.com:elastic/kibana into manage-spaces
thomheymann Jul 19, 2021
972a2f9
Added suggestions from code review
thomheymann Jul 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file modified docs/spaces/images/edit-space-feature-visibility.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified docs/spaces/images/edit-space.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
132 changes: 132 additions & 0 deletions .../public/management/edit_space/customize_space/__snapshots__/customize_space.test.tsx.snap
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

152 changes: 110 additions & 42 deletions .../management/edit_space/customize_space/__snapshots__/customize_space_avatar.test.tsx.snap
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

63 changes: 0 additions & 63 deletions ...public/management/edit_space/customize_space/__snapshots__/space_identifier.test.tsx.snap
View file
Open in desktop

This file was deleted.

Loading