Add ML usage collector descriptions to the schema.#100387
Merged
Conversation
pjhampton
added
Feature:Telemetry
reason:enhancement
auto-backport
pjhampton
added
release_note:skip
pgayvallet
approved these changes
May 20, 2021
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: cc @pjhampton |
afharo
approved these changes
May 20, 2021
Member
afharo
left a comment
afharo
left a comment
There was a problem hiding this comment.
LGTM! Thank you for adding this great piece of documentation! 🧡
| }, | ||
| search_count: { | ||
| type: 'long', | ||
| _meta: { description: 'The number of searches run by the datafeed' }, |
Member
There was a problem hiding this comment.
NIT: Should we mention when the counter is reset?
Contributor
Author
There was a problem hiding this comment.
I don't think it should reset. It is unique to the Datafeed. But I could be mistaken
spong
approved these changes
May 20, 2021
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
May 20, 2021
* Add ML usage collector descriptions to the schema. * Update the telemetry mappings file
Contributor
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
kibanamachine
added a commit
that referenced
this pull request
May 20, 2021
1 task
yctercero
pushed a commit
to yctercero/kibana
that referenced
this pull request
May 25, 2021
* Add ML usage collector descriptions to the schema. * Update the telemetry mappings file
pjhampton
added a commit
that referenced
this pull request
May 28, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the ML metric descriptions to the usage collector schema in the sec solution.
Checklist
The Pre-commit hooks + CI checks should suffice for backwards compatibility.
For maintainers