[Observability] [Cases] Cases in the observability app#100360
[Observability] [Cases] Cases in the observability app#100360stephmilovic wants to merge 31 commits intoelastic:cases-rbac-pocfrom
Conversation
| const FormWrapper = styled.div` | ||
| width: 100%; | ||
| `; | ||
| function CreateCaseFlyoutComponent({ |
There was a problem hiding this comment.
This is unused, but leaving here for when alerting is enabled unless someone objects?
legrego
left a comment
There was a problem hiding this comment.
Is the plan to merge this into the cases-rbac-poc branch before it merges to master, or will you rebase this against master once cases-rbac-poc merges?
I ask because cases-rbac-poc is already an enormous PR, and adding another large PR on top of it will make reviewing that much more difficult, especially for those of us who aren't intimately familiar with this part of the codebase.
@legrego definitely waiting for |
smith
left a comment
There was a problem hiding this comment.
Looks good overall but I found a few problems:
- When viewing an individual case, breadcrumb for "cases" isn't clickable. I think you might need to put an href property somewhere
- On the table, filtering by a tag using the filters always returns an empty list for me
- When viewing an individual case and deleting it, I'm taken back to the observability overview page instead of the list of cases
- Once I've deleted a case, if I go back to that URL (http://localhost:5701/kbn/app/observability/cases/cad584d0-bf03-11eb-a23c-5924635d118c), I get a blank page with a toast about an error fetching data. There should be some kind of not found page
x-pack/plugins/observability/public/hooks/use_get_cases_user_permissions.tsx
Show resolved
Hide resolved
x-pack/plugins/observability/public/hooks/use_get_cases_user_permissions.tsx
Outdated
Show resolved
Hide resolved
x-pack/plugins/observability/public/hooks/use_messages_storage.tsx
Outdated
Show resolved
Hide resolved
katrin-freihofner
left a comment
There was a problem hiding this comment.
@stephmilovic the screenshots look good to me (I don't have any data to try it). Looking forward to trying it out when it's ready!
no need for any index data! just go in and create a case, then you will have data ;) |
changes made! thank you! |
|
@elasticmachine merge upstream |
|
This PR was against the |
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
Summary
Cases in the observability app. Four new views:
1. All Cases
/observability/cases2. Create Case
/observability/cases/create3. Case Details
/observability/cases/:detailName4. Configure Case
/observability/cases/configureThere is still a flag on Observability/Cases in the sidebar menu:
xpack.observability.unsafe.alertingExperience.enabled: trueInternal ticket: https://github.com/elastic/security-team/issues/853
It's working! Still to do:
userPermissionsfor each pageconnectuseFetchAlertDataconnectshowAlertDetails(in security we open timeline)update values forruleDetailsNavigationuseFetchAlertData,showAlertDetails,ruleDetailsNavigation