Skip to content

[7.x] [Security Solutions] Removes deprecation and more copied code between security solutions and lists plugin (#100150)#100180

Merged
kibanamachine merged 1 commit intoelastic:7.xfrom
kibanamachine:backport/7.x/pr-100150
May 15, 2021
Merged

[7.x] [Security Solutions] Removes deprecation and more copied code between security solutions and lists plugin (#100150)#100180
kibanamachine merged 1 commit intoelastic:7.xfrom
kibanamachine:backport/7.x/pr-100150

Conversation

@kibanamachine
Copy link
Copy Markdown
Contributor

Backports the following commits to 7.x:

… security solutions and lists plugin (elastic#100150)

## Summary

* Removes deprecations 
* Removes duplicated code

### Checklist

- [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
@kibanamachine
Copy link
Copy Markdown
Contributor Author

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
lists 198 195 -3
securitySolution 2046 2112 +66
total +63

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
lists 241 210 -31

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
lists 68.4KB 55.2KB -13.1KB
securitySolution 6.7MB 6.7MB +30.4KB
total +17.2KB

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
lists 60 58 -2

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
lists 175.3KB 190.1KB +14.8KB
securitySolution 161.3KB 159.7KB -1.7KB
total +13.1KB
Unknown metric groups

API count

id before after diff
lists 263 232 -31

References to deprecated APIs

id before after diff
canvas 29 25 -4
crossClusterReplication 8 6 -2
fleet 4 2 -2
globalSearch 4 2 -2
indexManagement 12 7 -5
infra 5 3 -2
licensing 18 15 -3
monitoring 109 56 -53
total -73

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @FrankHassanabad

@kibanamachine kibanamachine merged commit a37a0c1 into elastic:7.x May 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants