[ui/tilemap] switch tile service based on env#10007
Merged
spalger merged 1 commit intoelastic:masterfrom Feb 21, 2017
Merged
Conversation
spalger
force-pushed
the
implement/tiles-stage-in-dev
branch
from
132cef9 to
47701f3
Compare
thomasneirynck
approved these changes
Jan 23, 2017
Contributor
thomasneirynck
left a comment
thomasneirynck
left a comment
There was a problem hiding this comment.
LGTM, it's a better approach.
thomasneirynck
added
the
Feature:Visualizations
thomasneirynck
pushed a commit
that referenced
this pull request
Feb 21, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We currently have the "prod" tile service hard coded in the 5.2 branch in preparation for release, and plan to switch master over once we branch in preparation for release. This means we are at risk of forgetting to switch it, and since we don't really have a process for ensuring we don't forget these types of things I think we need a different solution.
This adjusts the config to use a different default in dev and prod, so when we build Kibana it will automatically use the prod version, regardless of the branch.