-
Notifications
You must be signed in to change notification settings - Fork 8.5k
Description
In #49455, we've moved closer to the new platform, and made some changes to how requests are handled. Request handlers now get executed with the KibanaRequest object, the APMRequestContext object (which is an extension of Kibana's RequestContextobject), and the legacyServerobject. After that, most of the endpoints will callsetupRequestwithrequestandcontext(returning aSetup` object), to bootstrap some things, like getting the APM indices
There are several changes in NP that might affect this process:
- Exposing the internal repository for saved objects in NP: Split legacy plugin discovery, expose SavedObjects scopedClient, wrappers, repository #48882
- migrate usage collector to NP: collectorSets in the New Platform #46924
- removing data/admin client distinction for the ES client: Core Elasticsearch: remove "data" and "admin" clients and expose single client #49870
After this work has been completed we could consider the ramifications of our current abstractions, and see where we could possibly improve things. Right now there's some overlap between APMRequestContext and Setup, and in some cases we have to pass both objects around.