Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ilm] Remove observability solution dependency on index lifecycle management plugin bundle #199383

Merged
merged 9 commits into from
Nov 11, 2024
Merged

[ilm] Remove observability solution dependency on index lifecycle management plugin bundle #199383

merged 9 commits into from
Nov 11, 2024

Conversation

mattkime
Copy link
Contributor

@mattkime mattkime commented Nov 7, 2024 •
edited by kibanamachine
Loading

Create package for observability solution's dependencies from index lifecycle management. Previously it relied on the plugin bundle but thats best avoided with our sustainable architecture efforts.

Part of https://github.com/elastic/kibana-team/issues/1179

@mattkime
Copy link
Contributor Author

mattkime commented Nov 7, 2024

/ci

@mattkime
Copy link
Contributor Author

mattkime commented Nov 8, 2024

/ci

@mattkime
Copy link
Contributor Author

mattkime commented Nov 8, 2024

/ci

@mattkime
Copy link
Contributor Author

mattkime commented Nov 8, 2024

/ci

@mattkime mattkime self-assigned this Nov 8, 2024
@mattkime mattkime added Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more Feature:ILM release_note:skip Skip the PR/issue when compiling release notes backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) labels Nov 8, 2024
@mattkime mattkime changed the title move some dependencies to package [ilm] Remove observability solution dependency on index lifecycle management plugin bundle Nov 8, 2024
@mattkime mattkime marked this pull request as ready for review November 8, 2024 04:57
@mattkime mattkime requested review from a team as code owners November 8, 2024 04:57
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-management (Team:Kibana Management)

maryam-saeidi
maryam-saeidi approved these changes Nov 8, 2024
View reviewed changes
Copy link
Member

@maryam-saeidi maryam-saeidi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Import changes LGTM!

@botelastic botelastic bot added ci:project-deploy-observability Create an Observability project Team:obs-ux-management Observability Management User Experience Team labels Nov 8, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 8, 2024

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

afharo
afharo approved these changes Nov 8, 2024
View reviewed changes
Copy link
Member

@afharo afharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kibana.jsonc LGTM

ElenaStoeva
ElenaStoeva approved these changes Nov 8, 2024
View reviewed changes
Copy link
Contributor

@ElenaStoeva ElenaStoeva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes lgtm, tested ILM app locally.

@elasticmachine
Copy link
Contributor

elasticmachine commented Nov 10, 2024 •
edited
Loading

💚 Build Succeeded

  • Buildkite Build
  • Commit: 3440fc5
  • Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-199383-3440fc5ec9ff

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
indexLifecycleManagement 259 261 +2
synthetics 1037 1039 +2
total +4

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/index-lifecycle-management-common-shared - 73 +73

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
synthetics 1.1MB 1.1MB -25.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
synthetics 37.6KB 37.5KB -154.0B
Unknown metric groups

API count

id before after diff
@kbn/index-lifecycle-management-common-shared - 75 +75

References to deprecated APIs

id before after diff
indexLifecycleManagement 1 18 +17

History

cc @mattkime

@mattkime mattkime merged commit d805546 into elastic:main Nov 11, 2024
42 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/11770897866

@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
❌ 8.x Backport failed because of merge conflicts

You might need to backport the following PRs to 8.x:
- [OpenAPI][Fleet] Add missing operation summaries (#199548)
- Update serverless link targets (#199396)
- [Fleet] fix create package policy test (#199477)

Manual backport

To create the backport manually run:

node scripts/backport --pr 199383

Questions ?

Please refer to the Backport tool documentation

mattkime added a commit to mattkime/kibana that referenced this pull request Nov 11, 2024
@mattkime
[ilm] Remove observability solution dependency on index lifecycle man…
b78ff46 
…agement plugin bundle (elastic#199383)

Create package for observability solution's dependencies from index
lifecycle management. Previously it relied on the plugin bundle but
thats best avoided with our sustainable architecture efforts.

Part of elastic/kibana-team#1179

---------

Co-authored-by: kibanamachine <[email protected]>
(cherry picked from commit d805546)

# Conflicts:
#	.github/CODEOWNERS
CAWilson94 pushed a commit to CAWilson94/kibana-fork that referenced this pull request Nov 11, 2024
@mattkime @kibanamachine @CAWilson94
[ilm] Remove observability solution dependency on index lifecycle man…
7d68f9e 
…agement plugin bundle (elastic#199383)

Create package for observability solution's dependencies from index
lifecycle management. Previously it relied on the plugin bundle but
thats best avoided with our sustainable architecture efforts.

Part of elastic/kibana-team#1179

---------

Co-authored-by: kibanamachine <[email protected]>
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Nov 12, 2024
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 199383 locally

tkajtoch pushed a commit to tkajtoch/kibana that referenced this pull request Nov 12, 2024
@mattkime @kibanamachine @tkajtoch
[ilm] Remove observability solution dependency on index lifecycle man…
3b89c49 
…agement plugin bundle (elastic#199383)

Create package for observability solution's dependencies from index
lifecycle management. Previously it relied on the plugin bundle but
thats best avoided with our sustainable architecture efforts.

Part of elastic/kibana-team#1179

---------

Co-authored-by: kibanamachine <[email protected]>
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 199383 locally

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ElenaStoeva ElenaStoeva ElenaStoeva approved these changes

@maryam-saeidi maryam-saeidi maryam-saeidi approved these changes

@afharo afharo afharo approved these changes

Assignees

@mattkime mattkime

Labels
backport missing Added to PRs automatically when the are determined to be missing a backport. backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) ci:project-deploy-observability Create an Observability project Feature:ILM release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more Team:obs-ux-management Observability Management User Experience Team v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mattkime @elasticmachine @kibanamachine @afharo @maryam-saeidi @ElenaStoeva