[Unified Search] Data View Menu: Keyboard focus issues

[cchaos]

2.1. When choosing the option that closes the popover via keyboard the focus is lost

a11ypopover.mp4

3. Edit filter popover: Same here - before it was working by focusing the next element, now it looses focus (screenshot on state on main) after editing an existing filter

Originally posted by @mbondyra in #128401 (comment)

[cchaos]

@mbondyra & @stratoula I investigated the Data View menu return focus issue by narrowing it down to EuiSelectable within an EuIContextMenuPanel. I looked at how Lens was doing this in https://github.com/stratoula/kibana/blob/3d8c2551f0c3186a935e93c0fc197cecb5c311f7/x-pack/plugins/lens/public/indexpattern_datasource/change_indexpattern.tsx which works, and then wrapped the <DataViewsList> in an <EuiContextMenuPanel> and focus now gets lost after selection.

I'm not terribly familiar with programatic focus-management, so I can't tell if this is specifically an EUI issue or if we just need to manually handle this situation by adding a ref on the trigger button and forcing focus on index-pattern change.

I'm cc-ing @elastic/eui-design in case this sounds familiar to them.

[cchaos]

For no. 2 (the filter add button), I can't replicate the focus issues.

✅ When I open the popover and close it immediately, focus is returned.
✅ When I open the popover and add the filter, focus is returned to the add button.

[mbondyra]

@cchaos About the no. 2 - it doesn't happen for add the filter, it happens for when you edit the existing filter pill. It also happens for filter popover and data view menu. So basically all elements inside EuiContextMenu. I can also reproduce it in EUI. i've opened this issue: elastic/eui#5869

[cchaos]

Thank you @mbondyra !

[elasticmachine]

Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors)