Fix Jest tests

elastic · Nov 13, 2024 · f5dd06c · f5dd06c
1 parent 45cd5dd
commit f5dd06c
Show file tree

Hide file tree

Showing 6 changed files with 28 additions and 21 deletions.
diff --git a/x-pack/plugins/cases/common/utils/__snapshots__/api_tags.test.ts.snap b/x-pack/plugins/cases/common/utils/__snapshots__/api_tags.test.ts.snap
diff --git a/x-pack/plugins/cases/common/utils/capabilities.test.tsx b/x-pack/plugins/cases/common/utils/capabilities.test.tsx
@@ -17,6 +17,7 @@ describe('createUICapabilities', () => {
           "update_cases",
           "push_cases",
           "cases_connectors",
+          "cases_settings",
         ],
         "createComment": Array [
           "create_comment",

diff --git a/x-pack/plugins/cases/public/components/all_cases/use_actions.tsx b/x-pack/plugins/cases/public/components/all_cases/use_actions.tsx
@@ -145,7 +145,7 @@ const ActionColumnComponent: React.FC<{ theCase: CaseUI; disableActions: boolean
       mainPanelItems.push(deleteAction.getAction([theCase]));
     }
 
-    if (statusAction.canUpdateStatus) {
+    if (statusAction.canUpdateStatus || !shouldDisableStatus) {
       panelsToBuild.push({
         id: 1,
         title: i18n.STATUS,

diff --git a/x-pack/plugins/cases/public/components/all_cases/use_bulk_actions.test.tsx b/x-pack/plugins/cases/public/components/all_cases/use_bulk_actions.test.tsx
@@ -559,32 +559,37 @@ describe('useBulkActions', () => {
 
     it('shows the correct actions with reopen permissions', async () => {
       appMockRender = createAppMockRenderer({ permissions: onlyReopenCasesPermission() });
-      const { result, waitFor: waitForHook } = renderHook(
+      const { result } = renderHook(
         () => useBulkActions({ onAction, onActionSuccess, selectedCases: [basicCaseClosed] }),
         {
           wrapper: appMockRender.AppWrapper,
         }
       );
 
-      const modals = result.current.modals;
-      const panels = result.current.panels;
-
-      const res = appMockRender.render(
+      const { modals, flyouts, panels } = result.current;
+      const renderResult = appMockRender.render(
         <>
           <EuiContextMenu initialPanelId={0} panels={panels} />
           {modals}
+          {flyouts}
         </>
       );
 
-      await waitForHook(() => {
-        expect(res.queryByTestId('case-bulk-action-status')).toBeInTheDocument();
-        res.queryByTestId('case-bulk-action-status')?.click();
+      await waitFor(() => {
+        expect(renderResult.queryByTestId('case-bulk-action-status')).toBeInTheDocument();
+        expect(renderResult.queryByTestId('case-bulk-action-severity')).toBeInTheDocument();
+        expect(renderResult.queryByTestId('bulk-actions-separator')).not.toBeInTheDocument();
+        expect(renderResult.queryByTestId('case-bulk-action-delete')).not.toBeInTheDocument();
       });
 
-      await waitForHook(() => {
-        expect(res.queryByTestId('cases-bulk-action-status-open')).not.toBeDisabled();
-        expect(res.queryByTestId('cases-bulk-action-status-in-progress')).not.toBeDisabled();
-        expect(res.queryByTestId('cases-bulk-action-status-closed')).toBeDisabled();
+      userEvent.click(renderResult.getByTestId('case-bulk-action-status'));
+
+      await waitFor(() => {
+        expect(renderResult.queryByTestId('cases-bulk-action-status-open')).not.toBeDisabled();
+        expect(
+          renderResult.queryByTestId('cases-bulk-action-status-in-progress')
+        ).not.toBeDisabled();
+        expect(renderResult.queryByTestId('cases-bulk-action-status-closed')).not.toBeDisabled();
       });
     });
   });

diff --git a/x-pack/plugins/cases/public/components/all_cases/use_bulk_actions.tsx b/x-pack/plugins/cases/public/components/all_cases/use_bulk_actions.tsx
@@ -76,9 +76,6 @@ export const useBulkActions = ({
 
   const panels = useMemo((): EuiContextMenuPanelDescriptor[] => {
     const mainPanelItems: EuiContextMenuPanelItemDescriptor[] = [];
-    const panelsToBuild: EuiContextMenuPanelDescriptor[] = [
-      { id: 0, items: mainPanelItems, title: i18n.ACTIONS },
-    ];
 
     if (canUpdate) {
       mainPanelItems.push({
@@ -119,7 +116,13 @@ export const useBulkActions = ({
     if (canDelete) {
       mainPanelItems.push(deleteAction.getAction(selectedCases));
     }
-
+    const panelsToBuild: EuiContextMenuPanelDescriptor[] = [
+      {
+        id: 0,
+        items: [...mainPanelItems], // Create a new array instead of using reference
+        title: i18n.ACTIONS,
+      },
+    ];
     if (canUpdate) {
       panelsToBuild.push({
         id: 1,

diff --git a/x-pack/plugins/cases/public/components/all_cases/utility_bar.tsx b/x-pack/plugins/cases/public/components/all_cases/utility_bar.tsx
@@ -94,7 +94,8 @@ export const CasesTableUtilityBar: FunctionComponent<Props> = React.memo(
      * Granular permission check for each action is performed
      * in the useBulkActions hook.
      */
-    const showBulkActions = (permissions.update || permissions.delete) && selectedCases.length > 0;
+    const showBulkActions =
+      (permissions.update || permissions.delete || permissions.reopen) && selectedCases.length > 0;
 
     const visibleCases =
       pagination?.pageSize && totalCases > pagination.pageSize ? pagination.pageSize : totalCases;