addresses changes

elastic · Jun 12, 2024 · edd3b03 · edd3b03
1 parent ffb2aa0
commit edd3b03
Show file tree

Hide file tree

Showing 3 changed files with 160 additions and 124 deletions.
diff --git a/.../lib/detection_engine/prebuilt_rules/api/review_rule_upgrade/review_rule_upgrade_route.ts b/.../lib/detection_engine/prebuilt_rules/api/review_rule_upgrade/review_rule_upgrade_route.ts
@@ -126,7 +126,7 @@ const calculateRuleInfos = (results: CalculateRuleDiffResult[]): RuleUpgradeInfo
           (fieldDiff) =>
             fieldDiff.has_update ||
             fieldDiff.has_conflict ||
-            // For full transparancy we display all user-customized fields, even if nothing changes in the field's target or merged versions
+            // For full transparency we display all user-customized fields, even if nothing changes in the field's target or merged versions
             fieldDiff.diff_outcome === ThreeWayDiffOutcome.CustomizedValueNoUpdate ||
             fieldDiff.diff_outcome === ThreeWayDiffOutcome.CustomizedValueSameUpdate
         ),

diff --git a/.../lib/detection_engine/prebuilt_rules/logic/diff/calculation/calculate_rule_fields_diff.ts b/.../lib/detection_engine/prebuilt_rules/logic/diff/calculation/calculate_rule_fields_diff.ts
@@ -38,8 +38,8 @@ import type { ThreeVersionsOf } from '../../../../../../../common/api/detection_
 import { MissingVersion } from '../../../../../../../common/api/detection_engine/prebuilt_rules/model/diff/three_way_diff/three_way_diff';
 import { calculateFieldsDiffFor } from './diff_calculation_helpers';
 import {
-  simpleDiffAlgorithm,
   numberDiffAlgorithm,
+  simpleDiffAlgorithm,
   singleLineStringDiffAlgorithm,
 } from './algorithms';