Skip to content

Commit

Permalink
[Lens][FTR] Fix afterAll issue (#189069)
Browse files Browse the repository at this point in the history
## Summary

Fixes #189056, #189057, #164623

Bring back the window handler for other tests correctly.

---------

Co-authored-by: kibanamachine <[email protected]>
  • Loading branch information
dej611 and kibanamachine authored Jul 25, 2024
1 parent a35d317 commit c47f371
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 6 deletions.
5 changes: 3 additions & 2 deletions x-pack/test/functional/apps/lens/group1/ad_hoc_data_view.ts
Original file line number Diff line number Diff line change
Expand Up @@ -73,8 +73,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
expect(await dataViews.isAdHoc()).to.be(true);
};

// Failing: See https://github.com/elastic/kibana/issues/164623
describe.skip('lens ad hoc data view tests', () => {
describe('lens ad hoc data view tests', () => {
it('should allow building a chart based on ad hoc data view', async () => {
await setupAdHocDataView();
await PageObjects.lens.configureDimension({
Expand Down Expand Up @@ -223,6 +222,8 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
expect(await dataViews.isAdHoc()).to.be(true);

await browser.closeCurrentWindow();
const [lensHandle] = await browser.getAllWindowHandles();
await browser.switchToWindow(lensHandle);
});

// Failing: See https://github.com/elastic/kibana/issues/164623
Expand Down
3 changes: 1 addition & 2 deletions x-pack/test/functional/apps/lens/group1/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,7 @@ export default ({ getService, loadTestFile, getPageObjects }: FtrProviderContext
const config = getService('config');
let remoteEsArchiver;

// FLAKY: https://github.com/elastic/kibana/issues/189057
describe.skip('lens app - group 1', () => {
describe('lens app - group 1', () => {
const esArchive = 'x-pack/test/functional/es_archives/logstash_functional';
const localIndexPatternString = 'logstash-*';
const remoteIndexPatternString = 'ftr-remote:logstash-*';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -45,8 +45,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
).to.eql(expectedData);
}

// Failing: See https://github.com/elastic/kibana/issues/189056
describe.skip('lens with multiple data views', () => {
describe('lens with multiple data views', () => {
const visTitle = 'xyChart with multiple data views';

before(async () => {
Expand Down

0 comments on commit c47f371

Please sign in to comment.