updates test utils

elastic · Oct 9, 2024 · b2ed78a · b2ed78a
1 parent 9a0a1af
commit b2ed78a
Show file tree

Hide file tree

Showing 4 changed files with 17 additions and 16 deletions.
diff --git a/...r/lib/detection_engine/rule_management/logic/detection_rules_client/methods/patch_rule.ts b/...r/lib/detection_engine/rule_management/logic/detection_rules_client/methods/patch_rule.ts
@@ -52,10 +52,7 @@ export const patchRule = async ({
 
   await validateMlAuth(mlAuthz, rulePatch.type ?? existingRule.type);
 
-  // We don't allow non-customizable fields to be changed for prebuilt rules
-  if (existingRule.rule_source && existingRule.rule_source.type === 'external') {
-    validateNonCustomizablePatchFields(rulePatch, existingRule);
-  }
+  validateNonCustomizablePatchFields(rulePatch, existingRule);
 
   const patchedRule = await applyRulePatch({
     prebuiltRuleAssetClient,

diff --git a/.../lib/detection_engine/rule_management/logic/detection_rules_client/methods/update_rule.ts b/.../lib/detection_engine/rule_management/logic/detection_rules_client/methods/update_rule.ts
@@ -51,10 +51,7 @@ export const updateRule = async ({
     throw new ClientError(error.message, error.statusCode);
   }
 
-  // We don't allow non-customizable fields to be changed for prebuilt rules
-  if (existingRule.rule_source && existingRule.rule_source.type === 'external') {
-    validateNonCustomizableUpdateFields(ruleUpdate, existingRule);
-  }
+  validateNonCustomizableUpdateFields(ruleUpdate, existingRule);
 
   const ruleWithUpdates = await applyRuleUpdate({
     prebuiltRuleAssetClient,

diff --git a/...k/plugins/security_solution/server/lib/detection_engine/rule_management/utils/validate.ts b/...k/plugins/security_solution/server/lib/detection_engine/rule_management/utils/validate.ts
@@ -124,20 +124,26 @@ export const validateNonCustomizableUpdateFields = (
   ruleUpdate: RuleUpdateProps,
   existingRule: RuleResponse
 ) => {
-  if (!isEqual(ruleUpdate.author, existingRule.author)) {
-    throw new ClientError(`Cannot update "author" field for prebuilt rules`, 400);
-  } else if (ruleUpdate.license !== existingRule.license) {
-    throw new ClientError(`Cannot update "license" field for prebuilt rules`, 400);
+  // We don't allow non-customizable fields to be changed for prebuilt rules
+  if (existingRule.rule_source && existingRule.rule_source.type === 'external') {
+    if (!isEqual(ruleUpdate.author, existingRule.author)) {
+      throw new ClientError(`Cannot update "author" field for prebuilt rules`, 400);
+    } else if (ruleUpdate.license !== existingRule.license) {
+      throw new ClientError(`Cannot update "license" field for prebuilt rules`, 400);
+    }
   }
 };
 
 export const validateNonCustomizablePatchFields = (
   rulePatch: RulePatchProps,
   existingRule: RuleResponse
 ) => {
-  if (rulePatch.author && !isEqual(rulePatch.author, existingRule.author)) {
-    throw new ClientError(`Cannot update "author" field for prebuilt rules`, 400);
-  } else if (rulePatch.license && rulePatch.license !== existingRule.license) {
-    throw new ClientError(`Cannot update "license" field for prebuilt rules`, 400);
+  // We don't allow non-customizable fields to be changed for prebuilt rules
+  if (existingRule.rule_source && existingRule.rule_source.type === 'external') {
+    if (rulePatch.author && !isEqual(rulePatch.author, existingRule.author)) {
+      throw new ClientError(`Cannot update "author" field for prebuilt rules`, 400);
+    } else if (rulePatch.license != null && rulePatch.license !== existingRule.license) {
+      throw new ClientError(`Cannot update "license" field for prebuilt rules`, 400);
+    }
   }
 };
diff --git a/...st_suites/detections_response/utils/rules/get_rule_params/get_custom_query_rule_params.ts b/...st_suites/detections_response/utils/rules/get_rule_params/get_custom_query_rule_params.ts
@@ -29,6 +29,7 @@ export function getCustomQueryRuleParams(
     index: ['logs-*'],
     interval: '100m',
     from: 'now-6m',
+    author: [],
     enabled: false,
     ...rewrites,
   };