Do not call toggleRuleEnabledOnUpdate in upgradePrebuiltRule, sin…

…ce it won't do anything
elastic · Jun 18, 2024 · 8d3fe01 · 8d3fe01
1 parent bfcac78
commit 8d3fe01
Showing 1 changed file with 2 additions and 13 deletions.
diff --git a/...tion_engine/rule_management/logic/detection_rules_client/methods/upgrade_prebuilt_rule.ts b/...tion_engine/rule_management/logic/detection_rules_client/methods/upgrade_prebuilt_rule.ts
@@ -18,12 +18,7 @@ import { transformAlertToRuleAction } from '../../../../../../../common/detectio
 import { RuleResponse } from '../../../../../../../common/api/detection_engine/model/rule_schema';
 import { transform } from '../../../utils/utils';
 
-import {
-  validateMlAuth,
-  ClientError,
-  RuleResponseValidationError,
-  toggleRuleEnabledOnUpdate,
-} from '../utils';
+import { validateMlAuth, ClientError, RuleResponseValidationError } from '../utils';
 
 import { readRules } from '../read_rules';
 
@@ -90,12 +85,6 @@ export const upgradePrebuiltRule = async (
     data: patchedRule,
   });
 
-  const { enabled } = await toggleRuleEnabledOnUpdate(
-    rulesClient,
-    existingRule,
-    patchedInternalRule.enabled
-  );
-
   const updatedRule = await readRules({
     rulesClient,
     ruleId: ruleAsset.rule_id,
@@ -107,7 +96,7 @@ export const upgradePrebuiltRule = async (
   }
 
   /* Trying to convert the internal rule to a RuleResponse object */
-  const parseResult = RuleResponse.safeParse(transform({ ...patchedInternalRule, enabled }));
+  const parseResult = RuleResponse.safeParse(transform(patchedInternalRule));
 
   if (!parseResult.success) {
     throw new RuleResponseValidationError({