Fix TS issues

elastic · Sep 3, 2024 · 50413c4 · 50413c4
1 parent 47e73eb
commit 50413c4
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 5 deletions.
diff --git a/...ay_diff/final_readonly/fields/machine_learning_job_id/machine_learning_job_id.stories.tsx b/...ay_diff/final_readonly/fields/machine_learning_job_id/machine_learning_job_id.stories.tsx
@@ -66,7 +66,7 @@ interface TemplateProps {
 
 const Template: Story<TemplateProps> = (args) => {
   return (
-    <FinalReadOnlyStorybookProviders kibanaServicesMock={args.kibanaServicesMock}>
+    <FinalReadOnlyStorybookProviders>
       <MockMlData>
         <FinalReadOnly
           fieldName="machine_learning_job_id"

diff --git a/.../rule_management/components/rule_details/three_way_diff/final_readonly/final_readonly.tsx b/.../rule_management/components/rule_details/three_way_diff/final_readonly/final_readonly.tsx
@@ -6,7 +6,6 @@
  */
 
 import React from 'react';
-import { assertUnreachable } from '../../../../../../../common/utility_types';
 import type { DiffableAllFields } from '../../../../../../../common/api/detection_engine';
 import { KqlQueryReadOnly } from './fields/kql_query';
 import { DataSourceReadOnly } from './fields/data_source/data_source';
@@ -85,6 +84,6 @@ export function FinalReadOnly({ fieldName, finalDiffableRule }: FinalReadonlyPro
         />
       );
     default:
-      return assertUnreachable(fieldName);
+      return null;
   }
 }
diff --git a/...le_details/three_way_diff/final_readonly/storybook/final_readonly_storybook_providers.tsx b/...le_details/three_way_diff/final_readonly/storybook/final_readonly_storybook_providers.tsx
@@ -42,14 +42,14 @@ function createKibanaServicesMock(overrides?: Partial<CoreStart>) {
       },
     },
     uiSettings: {},
-  } as unknown as CoreStart;
+  };
 
   return merge(baseMock, overrides);
 }
 
 interface StorybookProvidersProps {
   children: React.ReactNode;
-  kibanaServicesMock?: ReturnType<typeof createKibanaServicesMock>;
+  kibanaServicesMock?: Record<string, unknown>;
 }
 
 export function FinalReadOnlyStorybookProviders({