addresses comments

elastic · Jun 13, 2024 · 2828693 · 2828693
1 parent 76f398c
commit 2828693
Showing 1 changed file with 1 addition and 6 deletions.
diff --git a/.../lib/detection_engine/prebuilt_rules/api/review_rule_upgrade/review_rule_upgrade_route.ts b/.../lib/detection_engine/prebuilt_rules/api/review_rule_upgrade/review_rule_upgrade_route.ts
@@ -123,12 +123,7 @@ const calculateRuleInfos = (results: CalculateRuleDiffResult[]): RuleUpgradeInfo
       diff: {
         fields: pickBy<ThreeWayDiff<unknown>>(
           ruleDiff.fields,
-          (fieldDiff) =>
-            fieldDiff.has_update ||
-            fieldDiff.has_conflict ||
-            // For full transparency we display all user-customized fields, even if nothing changes in the field's target or merged versions
-            fieldDiff.diff_outcome === ThreeWayDiffOutcome.CustomizedValueNoUpdate ||
-            fieldDiff.diff_outcome === ThreeWayDiffOutcome.CustomizedValueSameUpdate
+          (fieldDiff) => fieldDiff.diff_outcome !== ThreeWayDiffOutcome.StockValueNoUpdate
         ),
         has_conflict: ruleDiff.has_conflict,
       },