Skip to content

Commit 2691694

Browse files
author
Tyler Smalley
authored
Revert "Disables Chromedriver version detection (#75984)" (#77489) (#77513)
This reverts commit 595dfdb.
1 parent 77974fd commit 2691694

File tree

2 files changed

+7
-13
lines changed

2 files changed

+7
-13
lines changed

src/dev/ci_setup/setup.sh

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -16,12 +16,6 @@ echo " -- TEST_ES_SNAPSHOT_VERSION='$TEST_ES_SNAPSHOT_VERSION'"
1616
echo " -- installing node.js dependencies"
1717
yarn kbn bootstrap --prefer-offline
1818

19-
###
20-
### ensure Chromedriver install hook is triggered
21-
### when modules are up-to-date
22-
###
23-
node node_modules/chromedriver/install.js
24-
2519
###
2620
### Download es snapshots
2721
###

src/dev/ci_setup/setup_env.sh

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -133,13 +133,13 @@ export CYPRESS_DOWNLOAD_MIRROR="https://us-central1-elastic-kibana-184716.cloudf
133133
export CHECKS_REPORTER_ACTIVE=false
134134

135135
# This is mainly for release-manager builds, which run in an environment that doesn't have Chrome installed
136-
# if [[ "$(which google-chrome-stable)" || "$(which google-chrome)" ]]; then
137-
# echo "Chrome detected, setting DETECT_CHROMEDRIVER_VERSION=true"
138-
# export DETECT_CHROMEDRIVER_VERSION=true
139-
# export CHROMEDRIVER_FORCE_DOWNLOAD=true
140-
# else
141-
# echo "Chrome not detected, installing default chromedriver binary for the package version"
142-
# fi
136+
if [[ "$(which google-chrome-stable)" || "$(which google-chrome)" ]]; then
137+
echo "Chrome detected, setting DETECT_CHROMEDRIVER_VERSION=true"
138+
export DETECT_CHROMEDRIVER_VERSION=true
139+
export CHROMEDRIVER_FORCE_DOWNLOAD=true
140+
else
141+
echo "Chrome not detected, installing default chromedriver binary for the package version"
142+
fi
143143

144144
### only run on pr jobs for elastic/kibana, checks-reporter doesn't work for other repos
145145
if [[ "$ghprbPullId" && "$ghprbGhRepository" == 'elastic/kibana' ]] ; then

0 commit comments

Comments
 (0)