Skip to content

Commit 595dfdb

Browse files
author
Tyler Smalley
authored
Disables Chromedriver version detection (#75984)
Signed-off-by: Tyler Smalley <[email protected]>
1 parent d2d7b0d commit 595dfdb

File tree

2 files changed

+13
-7
lines changed

2 files changed

+13
-7
lines changed

src/dev/ci_setup/setup.sh

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,12 @@ echo " -- TEST_ES_SNAPSHOT_VERSION='$TEST_ES_SNAPSHOT_VERSION'"
1616
echo " -- installing node.js dependencies"
1717
yarn kbn bootstrap --prefer-offline
1818

19+
###
20+
### ensure Chromedriver install hook is triggered
21+
### when modules are up-to-date
22+
###
23+
node node_modules/chromedriver/install.js
24+
1925
###
2026
### Download es snapshots
2127
###

src/dev/ci_setup/setup_env.sh

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -134,13 +134,13 @@ export CYPRESS_DOWNLOAD_MIRROR="https://us-central1-elastic-kibana-184716.cloudf
134134
export CHECKS_REPORTER_ACTIVE=false
135135

136136
# This is mainly for release-manager builds, which run in an environment that doesn't have Chrome installed
137-
if [[ "$(which google-chrome-stable)" || "$(which google-chrome)" ]]; then
138-
echo "Chrome detected, setting DETECT_CHROMEDRIVER_VERSION=true"
139-
export DETECT_CHROMEDRIVER_VERSION=true
140-
export CHROMEDRIVER_FORCE_DOWNLOAD=true
141-
else
142-
echo "Chrome not detected, installing default chromedriver binary for the package version"
143-
fi
137+
# if [[ "$(which google-chrome-stable)" || "$(which google-chrome)" ]]; then
138+
# echo "Chrome detected, setting DETECT_CHROMEDRIVER_VERSION=true"
139+
# export DETECT_CHROMEDRIVER_VERSION=true
140+
# export CHROMEDRIVER_FORCE_DOWNLOAD=true
141+
# else
142+
# echo "Chrome not detected, installing default chromedriver binary for the package version"
143+
# fi
144144

145145
### only run on pr jobs for elastic/kibana, checks-reporter doesn't work for other repos
146146
if [[ "$ghprbPullId" && "$ghprbGhRepository" == 'elastic/kibana' ]] ; then

0 commit comments

Comments
 (0)