Skip to content

Conversation

@fearful-symmetry
Copy link
Contributor

@fearful-symmetry fearful-symmetry commented Apr 30, 2024

closes: elastic/beats#38708
For more context: elastic/beats#39205

This PR adds support in integrations for the new queue percentage full metric. As part of this, we:

  • Add a Queue Usage panel to the agent metrics dashboard
  • Add a queue.filled.pct.events field to the integrations

I haven't tinkered with integrations in ages, so...I hopefully haven't broken anything.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
Screenshot 2024-05-01 at 1 49 16 PM

@fearful-symmetry fearful-symmetry added the Team:Elastic-Agent Platform - Ingest - Agent [elastic/elastic-agent] label Apr 30, 2024
@fearful-symmetry fearful-symmetry self-assigned this Apr 30, 2024
@fearful-symmetry fearful-symmetry requested a review from a team as a code owner April 30, 2024 21:03
@elasticmachine
Copy link

Pinging @elastic/elastic-agent (Team:Elastic-Agent)

@ycombinator
Copy link
Contributor

@fearful-symmetry Would you mind adding a screenshot of the new panel in the dashboard to this PR's description?

@cmacknz cmacknz requested a review from leehinman May 1, 2024 16:05
@leehinman
Copy link
Contributor

@fearful-symmetry the code changes look fine, but holding off approval till we get a screen shot. I'm not very good at rendering those kibana json files into dashboards in my head :-)

@fearful-symmetry
Copy link
Contributor Author

Alright, uploaded a screenshot. Also made me realize that I didn't set the percentage correctly. I think it's right now?

@elasticmachine
Copy link

💚 Build Succeeded

History

cc @fearful-symmetry

@elastic-sonarqube
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@fearful-symmetry
Copy link
Contributor Author

@leehinman / @ycombinator

Copy link
Contributor

@leehinman leehinman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fearful-symmetry fearful-symmetry merged commit 12c0f68 into elastic:main May 2, 2024
@elasticmachine
Copy link

Package elastic_agent - 1.19.0 containing this change is available at https://epr.elastic.co/search?package=elastic_agent

@elasticmachine
Copy link

Package elastic_agent - 1.19.1 containing this change is available at https://epr.elastic.co/search?package=elastic_agent

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Integration:elastic_agent Elastic Agent Team:Elastic-Agent Platform - Ingest - Agent [elastic/elastic-agent]

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add metric for queue utilization percentage

5 participants