Skip to content

Add capabilities to synthetics packages#9066

Merged
jsoriano merged 2 commits intoelastic:mainfrom
jsoriano:synthetics-capabilities
Feb 7, 2024
Merged

Add capabilities to synthetics packages#9066
jsoriano merged 2 commits intoelastic:mainfrom
jsoriano:synthetics-capabilities

Conversation

@jsoriano
Copy link
Member

@jsoriano jsoriano commented Feb 6, 2024

Proposed commit message

Add capabilities to synthetics packages so they are not available in offerings that miss these capabilities.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
    Not added because this would release a new version, that would not be filtered because of special case in Kibana.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

@jsoriano jsoriano requested a review from a team February 6, 2024 11:27
@jsoriano jsoriano self-assigned this Feb 6, 2024
@jsoriano jsoriano requested a review from a team February 6, 2024 11:27
Comment on lines +28 to +30
elastic:
capabilities:
- "uptime"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@elastic/obs-ux-infra_services-team we only have an uptime capability now, do you think that we need to differentiate between uptime and synthetics?

cc @elastic/ecosystem

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, Synthetics utilizes the uptime capability in Kibana.

Copy link
Contributor

@justinkambic justinkambic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Comment on lines +28 to +30
elastic:
capabilities:
- "uptime"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, Synthetics utilizes the uptime capability in Kibana.

Copy link
Collaborator

@mrodm mrodm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jsoriano jsoriano requested a review from justinkambic February 6, 2024 23:40
@elasticmachine
Copy link

💚 Build Succeeded

History

cc @jsoriano

@elastic-sonarqube
Copy link

Quality Gate passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No Coverage information No data about Coverage
No Duplication information No data about Duplication

See analysis details on SonarQube

Copy link
Contributor

@justinkambic justinkambic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jsoriano jsoriano merged commit 9a484cc into elastic:main Feb 7, 2024
@jsoriano jsoriano deleted the synthetics-capabilities branch February 7, 2024 15:02
@elasticmachine
Copy link

Package synthetics_dashboards - 1.0.1 containing this change is available at https://epr.elastic.co/search?package=synthetics_dashboards

@andrewkroh andrewkroh added Integration:synthetics Elastic Synthetics Integration:synthetics_dashboards Elastic Synthetics Dashboards labels Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Integration:synthetics_dashboards Elastic Synthetics Dashboards Integration:synthetics Elastic Synthetics

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants