Skip to content

[Buildkite] Update condition to check whether or not a build is a PR #8640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mrodm merged 2 commits into from
Dec 4, 2023
Merged

[Buildkite] Update condition to check whether or not a build is a PR #8640

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
37d88be
Update condition to check whether or not a build is a PR
mrodm Dec 4, 2023
3a70ae2
Apply suggestions from code review
mrodm Dec 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .buildkite/scripts/common.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -590,10 +590,10 @@ is_pr_affected() {
}

is_pr() {
if [[ "${BUILDKITE_PULL_REQUEST}" == "false" || "${BUILDKITE_TAG}" == "" ]]; then
return 0
if [[ "${BUILDKITE_PULL_REQUEST}" == "false" && "${BUILDKITE_TAG}" == "" ]]; then
return 1
fi
return 1
return 0
}

kubernetes_service_deployer_used() {
Expand Down
2 changes: 1 addition & 1 deletion .buildkite/scripts/process_benchmarks.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ set -euo pipefail
BENCHMARK_THRESHOLD=${BENCHMARK_THRESHOLD:-'15'}

if ! is_pr ; then
echo "[benchmarks] Pull request build. Skip procesing benchmarks."
echo "[benchmarks] Not pull request build. Skip procesing benchmarks."
Comment thread
mrodm marked this conversation as resolved.
Outdated
exit 0
fi

Expand Down