[ti_rapid7_threat_command] Fix required stack capabilities#8268
Merged
jsoriano merged 2 commits intoelastic:mainfrom Oct 24, 2023
Merged
[ti_rapid7_threat_command] Fix required stack capabilities#8268jsoriano merged 2 commits intoelastic:mainfrom
jsoriano merged 2 commits intoelastic:mainfrom
Conversation
Collaborator
|
Two versions 1.10.0 and 1.11.0 should be removed: $ curl -s "https://epr.elastic.co/search?package=ti_rapid7_threat_command&spec.min=3.0&all=true" | jq -r '.[]|.version'
1.10.0
1.11.0 |
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsExpand to view the GitHub comments
To re-run your PR in the CI, just comment with:
|
🌐 Coverage report
|
mrodm
approved these changes
Oct 23, 2023
Collaborator
mrodm
left a comment
mrodm
left a comment
There was a problem hiding this comment.
LGTM
Just a suggestion to update changelog link
| changes: | ||
| - description: 'Fix required stack capabilities' | ||
| type: bugfix | ||
| link: https://github.com/elastic/integrations/pull/1 |
Collaborator
There was a problem hiding this comment.
Nit
Suggested change
| link: https://github.com/elastic/integrations/pull/1 | |
| link: https://github.com/elastic/integrations/pull/8268 |
efd6
approved these changes
Oct 23, 2023
|
Package ti_rapid7_threat_command - 1.11.1 containing this change is available at https://epr.elastic.co/search?package=ti_rapid7_threat_command |
2 tasks
kibanamachine
added a commit
to fkanout/kibana
that referenced
this pull request
Nov 27, 2023
## Summary [Fleet] Improve error handling on epm endpoints. Currently most errors occurring when doing any operation with packages will throw and result in a `500` in the correspondent endpoint. This PR is an attempts to handle those errors in a more comprehensive way and to return meaningful responses. Where I can I'm replacing the generic `Error` with `FleetError`; it calls `Logger.error` and checks if the error belongs to a specific type, if not defaults to 500. The error described in elastic/integrations#8268 will now return a 400: https://github.com/elastic/kibana/pull/171722/files#diff-952b3c1842d5d24d9e70833cae1683e2d78df7b489dc99665dab723cc10927c1R349-R352 ### Checklist - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
andrewkroh
added
the
Integration:ti_rapid7_threat_command
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed commit message
This package fails to start in stacks without the security plugin, as it requires
the security rule object type.
When trying to install with
elastic-package install:Add the required capabilities to the manifest.
As a follow up we will need to remove the 1.10.0 and 1.11.0 versions of the package from the registry. cc @mrodm
Checklist
changelog.ymlfile.Related issues
Screenshots