Skip to content

TYCHON Agentless Modular Pull Request for Code Review#8212

Closed
joeperuzzi wants to merge 84 commits intoelastic:mainfrom
joeperuzzi:tychon_modular
Closed

TYCHON Agentless Modular Pull Request for Code Review#8212
joeperuzzi wants to merge 84 commits intoelastic:mainfrom
joeperuzzi:tychon_modular

Conversation

@joeperuzzi
Copy link

The first dataset push for review, this code base has not been tested and does not build, however, at the request of the team we have broken up the datasets to make the code review process easier.

Please see closed PR:
#8123

joeperuzzi and others added 30 commits June 26, 2023 16:47
Co-authored-by: Dan Kortschak <90160302+efd6@users.noreply.github.com>
Co-authored-by: Dan Kortschak <90160302+efd6@users.noreply.github.com>
Co-authored-by: Dan Kortschak <90160302+efd6@users.noreply.github.com>
Co-authored-by: Dan Kortschak <90160302+efd6@users.noreply.github.com>
….hbs

Co-authored-by: Dan Kortschak <90160302+efd6@users.noreply.github.com>
Changed {{#each paths as |path i|}} to {{#each paths as |path|}} per efd6 request
Added new line to end per efd6 request.
Updated ecs.version per efd6 request
Added new line to end per efd6 request
Added descriptions to names.
Removed Asset Identification and updated exported field for tychon_cve
tychon1 and others added 24 commits August 30, 2023 19:34
Fixed issues with pipeline test failures
Initial commit of modularized components for code review
@joeperuzzi joeperuzzi mentioned this pull request Oct 16, 2023
1 task
@elasticmachine
Copy link

elasticmachine commented Oct 16, 2023

❕ Build Aborted

The PR is not allowed to run in the CI yet

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Start Time: 2023-11-03T16:23:32.138+0000

  • Duration: 4 min 38 sec

Steps errors 2

Expand to view the steps failures

Load a resource file from a library
  • Took 0 min 0 sec . View more details here
  • Description: approval-list/elastic/integrations.yml
Error signal
  • Took 0 min 0 sec . View more details here
  • Description: githubApiCall: The REST API call https://api.github.com/orgs/elastic/members/joeperuzzi return the message : java.lang.Exception: httpRequest: Failure connecting to the service https://api.github.com/orgs/elastic/members/joeperuzzi : httpRequest: Failure connecting to the service https://api.github.com/orgs/elastic/members/joeperuzzi : Code: 404Error: {"message":"User does not exist or is not a member of the organization","documentation_url":"https://docs.github.com/rest/orgs/members#check-organization-membership-for-a-user"}

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@efd6
Copy link
Contributor

efd6 commented Oct 17, 2023

What I was thinking is to start like this. Do this for each of the datastreams (this can happen in one PR after the system tests and other issues that I raise there are dealt with) and then (also possibly in the same PR) add the kibana components back in.

The commits in that PR are there to show the changes that are needed, but really we don't want multiple commits in a PR if it can be avoided since it muddies discussion; the 80+ commit here are too many.

@joeperuzzi joeperuzzi closed this Nov 3, 2023
@mergify
Copy link
Contributor

mergify bot commented Nov 3, 2023

⚠️ The sha of the head commit of this PR conflicts with #8400. Mergify cannot evaluate rules on this PR. ⚠️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants