Skip to content

[Logstash] Update manifest format_version to 3.0.0 for logstash integ…#8166

Merged
robbavey merged 2 commits intoelastic:mainfrom
robbavey:logstash_serverless_opt_in
Oct 17, 2023
Merged

[Logstash] Update manifest format_version to 3.0.0 for logstash integ…#8166
robbavey merged 2 commits intoelastic:mainfrom
robbavey:logstash_serverless_opt_in

Conversation

@robbavey
Copy link
Copy Markdown
Member

…ration package

Proposed commit message

Make changes to logstash package to allow it to opt-in for serverless:

  • Convert existing logs and slowlogs visualizations to lens
  • Remove unnecessary links between dashboards and visualizations
  • Update type: object field mappings to more suitable types
  • Add observability capability to manifest
  • Set type to owner field
  • Fix event.type values in ingest pipelines and tests to explicitly set an array
  • Add validation.yml to skip tests for mandatory filters in dashboards

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

#8098

…ration package

Make changes to logstash package to allow it to opt-in for serverless:

* Convert existing logs and slowlogs visualizations to lens
* Remove unnecessary links between dashboards and visualizations
* Update `type: object` field mappings to more suitable types
* Add `observability` capability to manifest
* Set `type` to `owner` field
* Fix `event.type` values in ingest pipelines and tests to explicitly set an array
* Add validation.yml to skip tests for mandatory filters in dashboards
@robbavey robbavey requested a review from a team as a code owner October 11, 2023 19:41
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Oct 11, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-10-11T19:42:51.175+0000

  • Duration: 24 min 40 sec

Test stats 🧪

Test Results
Failed 0
Passed 37
Skipped 0
Total 37

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link
Copy Markdown

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (2/2) 💚
Files 100.0% (6/6) 💚
Classes 100.0% (6/6) 💚
Methods 100.0% (55/55) 💚 75.0
Lines 87.558% (190/217) 👎 -12.442
Conditionals 100.0% (0/0) 💚

Copy link
Copy Markdown
Contributor

@klacabane klacabane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested both stack monitoring UI and dashboards, looks great!

@robbavey robbavey merged commit ea11ce8 into elastic:main Oct 17, 2023
@elasticmachine
Copy link
Copy Markdown

Package logstash - 2.3.5 containing this change is available at https://epr.elastic.co/search?package=logstash

@elasticmachine
Copy link
Copy Markdown

Package logstash - 2.3.6 containing this change is available at https://epr.elastic.co/search?package=logstash

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants